Merge pull request #6051 from destiny-wu/pie-chart-negative-sum-drop

Discard negative values from pie chart post-aggregation instead of during summation

Author: archmoj

draftlogs/6051_fix.md

@@ -0,0 +1 @@
+- Discard negative values from pie chart post-aggregation instead of during summation [[#6051](https://github.com/plotly/plotly.js/pull/6051)]

src/traces/pie/calc.js

@@ -39,7 +39,6 @@ function calc(gd, trace) {
             v = vals[i];
             if(!isNumeric(v)) continue;
             v = +v;
-            if(v < 0) continue;
         } else v = 1;
 
         label = labels[i];
@@ -76,6 +75,9 @@ function calc(gd, trace) {
         }
     }
 
+    // Drop aggregate sums of value 0 or less
+    cd = cd.filter(function(elem) { return elem.v >= 0; });
+
     var shouldSort = (trace.type === 'funnelarea') ? isAggregated : trace.sort;
     if(shouldSort) cd.sort(function(a, b) { return b.v - a.v; });
 

test/image/baselines/z-pie_negative_values.png

@@ -0,0 +1,41 @@
+{
+    "data": [
+      {
+          "labels": [
+            "Apples",
+            "Apples",
+            "Bananas",
+            "Oranges",
+            "Pears",
+            "Pears",
+            "Apples",
+            "Pears"
+          ],
+          "type": "pie",
+          "domain": {"x": [0, 0.4]}
+      },
+      {
+          "labels": [
+              "Apples",
+              "Apples",
+              "Bananas",
+              "Oranges",
+              "Pears",
+              "Pears",
+              "Apples",
+              "Pears"
+          ],
+          "values": [
+              10, -20, 20, 40, 10, -20, 70, 5
+          ],
+          "marker": {"colors": ["", "", "#ccc"]},
+          "type": "pie",
+          "domain": {"x": [0.5, 1]},
+          "textinfo": "label+value+percent"
+      }
+    ],
+    "layout": {
+      "height": 300,
+      "width": 500
+    }
+}