Skip to content

Commit 789d7c7

Browse files
committed
fix default trace orders when zorder is present for some
1 parent 482802b commit 789d7c7

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

src/plots/cartesian/index.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,8 @@ function plotOne(gd, plotinfo, cdSubplot, transitionOpts, makeOnCompleteCallback
221221
var categories = Registry.modules[name].categories;
222222

223223
if(categories.svg) {
224-
var className = (_module.layerName || name + 'layer') + (z ? Number(z) + 1 : '');
224+
var classBaseName = (_module.layerName || name + 'layer');
225+
var className = classBaseName + (z ? Number(z) + 1 : '');
225226
var plotMethod = _module.plot;
226227

227228
// plot all visible traces of this type on this subplot at once
@@ -233,7 +234,7 @@ function plotOne(gd, plotinfo, cdSubplot, transitionOpts, makeOnCompleteCallback
233234

234235
if(cdModule.length) {
235236
layerData.push({
236-
i: traceLayerClasses.indexOf(className),
237+
i: traceLayerClasses.indexOf(classBaseName),
237238
zorder: z,
238239
className: className,
239240
plotMethod: plotMethod,
@@ -248,7 +249,12 @@ function plotOne(gd, plotinfo, cdSubplot, transitionOpts, makeOnCompleteCallback
248249
}
249250
}
250251
// Sort the layers primarily by z, then by i
251-
layerData.sort(function(a, b) { return (a.zorder || 0) - (b.zorder || 0) || a.i - b.i; });
252+
layerData.sort(function(a, b) {
253+
return (
254+
(a.zorder || 0) - (b.zorder || 0) ||
255+
(a.i - b.i)
256+
);
257+
});
252258

253259
var layers = plotinfo.plot.selectAll('g.mlayer')
254260
.data(layerData, function(d) { return d.className; });

0 commit comments

Comments
 (0)