Skip to content

Commit 7642e51

Browse files
authored
Merge pull request #7254 from plotly/remove-transforms-bundle-option
Remove transforms from bundles
2 parents 1f36292 + c7a8889 commit 7642e51

23 files changed

+9
-117
lines changed

CUSTOM_BUNDLE.md

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Custom bundle
2-
You can simply make custom bundles yourself, if none of the [distributed packages](https://github.com/plotly/plotly.js/blob/master/dist/README.md) meet your needs, or you want to make a more optimized bundle file with/without specific traces and transforms.
2+
You can simply make custom bundles yourself, if none of the [distributed packages](https://github.com/plotly/plotly.js/blob/master/dist/README.md) meet your needs, or you want to make a more optimized bundle file with/without specific traces.
33

44
Make sure you have the versions of node/npm that's recommended:
55
- plotly.js before 2.5: Node 12/npm 6
@@ -27,7 +27,7 @@ cd plotly.js
2727
npm i
2828
```
2929

30-
By default all traces and transforms are included in the bundle if you simply run:
30+
By default all traces are included in the bundle if you simply run:
3131
```sh
3232
npm run custom-bundle
3333
```
@@ -39,16 +39,6 @@ npm run custom-bundle -- --traces scatter,scattergl,scatter3d
3939
Please note that the `scatter` trace is currently included in all bundles and cannot be removed.
4040
[This behaviour may change in the future](https://github.com/plotly/plotly.js/pull/5535), so we recommend that you explicitly include `scatter` anyway if you need it in your bundle.
4141

42-
Use the `transforms` option to specify which should be included.
43-
```sh
44-
npm run custom-bundle -- --transforms sort,filter
45-
```
46-
47-
Or use `transforms none` to exclude them all.
48-
```sh
49-
npm run custom-bundle -- --transforms none
50-
```
51-
5242
Use the `strict` option to use strict trace types where possible.
5343
```sh
5444
npm run custom-bundle -- --traces scatter,scattergl --strict
@@ -66,15 +56,14 @@ npm run custom-bundle -- --unminified
6656
```
6757

6858
# Example illustrating use of different options together
69-
To create an unminified custom bundle named `myScatters` including `scatter`, `scattergl` and `scatter3d` traces without any transforms:
59+
To create an unminified custom bundle named `myScatters` including `scatter`, `scattergl` and `scatter3d` traces:
7060
```sh
7161
npm run custom-bundle -- \
7262
--unminified \
7363
--out myScatters \
7464
--traces scatter,scattergl,scatter3d \
75-
--transforms none
7665
```
7766
Or simply on one line:
7867
```sh
79-
npm run custom-bundle -- --unminified --out myScatters --traces scatter,scattergl,scatter3d --transforms none
68+
npm run custom-bundle -- --unminified --out myScatters --traces scatter,scattergl,scatter3d
8069
```

draftlogs/7240_remove.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
- Drop transforms from the API [[#7240](https://github.com/plotly/plotly.js/pull/7240)]
1+
- Drop transforms from the API [[#7240](https://github.com/plotly/plotly.js/pull/7240), [#7254](https://github.com/plotly/plotly.js/pull/7254)]

lib/aggregate.js

Lines changed: 0 additions & 3 deletions
This file was deleted.

lib/filter.js

Lines changed: 0 additions & 3 deletions
This file was deleted.

lib/groupby.js

Lines changed: 0 additions & 3 deletions
This file was deleted.

lib/index-basic.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,6 @@ Plotly.register([
77
require('./bar'),
88
require('./pie'),
99

10-
// transforms
11-
require('./aggregate'),
12-
require('./filter'),
13-
require('./groupby'),
14-
require('./sort'),
15-
1610
// components
1711
require('./calendars'),
1812
]);

lib/index-cartesian.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,6 @@ Plotly.register([
1616
require('./image'),
1717
require('./pie'),
1818

19-
// transforms
20-
require('./aggregate'),
21-
require('./filter'),
22-
require('./groupby'),
23-
require('./sort'),
24-
2519
// components
2620
require('./calendars'),
2721
]);

lib/index-finance.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,6 @@ Plotly.register([
1414
require('./ohlc'),
1515
require('./candlestick'),
1616

17-
// transforms
18-
require('./aggregate'),
19-
require('./filter'),
20-
require('./groupby'),
21-
require('./sort'),
22-
2317
// components
2418
require('./calendars'),
2519
]);

lib/index-geo.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,6 @@ Plotly.register([
77
require('./scattergeo'),
88
require('./choropleth'),
99

10-
// transforms
11-
require('./aggregate'),
12-
require('./filter'),
13-
require('./groupby'),
14-
require('./sort'),
15-
1610
// components
1711
require('./calendars'),
1812
]);

lib/index-gl2d.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,6 @@ Plotly.register([
88
require('./splom'),
99
require('./parcoords'),
1010

11-
// transforms
12-
require('./aggregate'),
13-
require('./filter'),
14-
require('./groupby'),
15-
require('./sort'),
16-
1711
// components
1812
require('./calendars'),
1913
]);

0 commit comments

Comments
 (0)