Skip to content

Commit 639d4bb

Browse files
committed
include optional hoverLayer arg in opts passed to hoverPoints
1 parent cb5698a commit 639d4bb

File tree

5 files changed

+19
-8
lines changed

5 files changed

+19
-8
lines changed

src/components/fx/hover.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -490,7 +490,10 @@ function _hover(gd, evt, subplot, noHoverEvent) {
490490
// Now if there is range to look in, find the points to hover.
491491
if(hoverdistance !== 0) {
492492
if(trace._module && trace._module.hoverPoints) {
493-
var newPoints = trace._module.hoverPoints(pointData, xval, yval, mode, fullLayout._hoverlayer);
493+
var newPoints = trace._module.hoverPoints(pointData, xval, yval, mode, {
494+
hoverLayer: fullLayout._hoverlayer
495+
});
496+
494497
if(newPoints) {
495498
var newPoint;
496499
for(var newPointNum = 0; newPointNum < newPoints.length; newPointNum++) {
@@ -519,7 +522,9 @@ function _hover(gd, evt, subplot, noHoverEvent) {
519522
if(hoverData.length === 0) {
520523
pointData.distance = spikedistance;
521524
pointData.index = false;
522-
var closestPoints = trace._module.hoverPoints(pointData, xval, yval, 'closest', fullLayout._hoverlayer);
525+
var closestPoints = trace._module.hoverPoints(pointData, xval, yval, 'closest', {
526+
hoverLayer: fullLayout._hoverlayer
527+
});
523528
if(closestPoints) {
524529
closestPoints = closestPoints.filter(function(point) {
525530
// some hover points, like scatter fills, do not allow spikes,

src/traces/contour/hover.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,11 @@ var Color = require('../../components/color');
44

55
var heatmapHoverPoints = require('../heatmap/hover');
66

7-
module.exports = function hoverPoints(pointData, xval, yval, hovermode, hoverLayer) {
8-
var hoverData = heatmapHoverPoints(pointData, xval, yval, hovermode, hoverLayer, {isContour: true});
7+
module.exports = function hoverPoints(pointData, xval, yval, hovermode, opts) {
8+
if(!opts) opts = {};
9+
opts.isContour = true;
10+
11+
var hoverData = heatmapHoverPoints(pointData, xval, yval, hovermode, opts);
912

1013
if(hoverData) {
1114
hoverData.forEach(function(hoverPt) {

src/traces/heatmap/hover.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ var Lib = require('../../lib');
55
var Axes = require('../../plots/cartesian/axes');
66
var extractOpts = require('../../components/colorscale').extractOpts;
77

8-
module.exports = function hoverPoints(pointData, xval, yval, hovermode, hoverLayer, opts) {
8+
module.exports = function hoverPoints(pointData, xval, yval, hovermode, opts) {
99
if(!opts) opts = {};
1010
var isContour = opts.isContour;
1111

src/traces/histogram2d/hover.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
var heatmapHover = require('../heatmap/hover');
44
var hoverLabelText = require('../../plots/cartesian/axes').hoverLabelText;
55

6-
module.exports = function hoverPoints(pointData, xval, yval, hovermode, hoverLayer, opts) {
7-
var pts = heatmapHover(pointData, xval, yval, hovermode, hoverLayer, opts);
6+
module.exports = function hoverPoints(pointData, xval, yval, hovermode, opts) {
7+
var pts = heatmapHover(pointData, xval, yval, hovermode, opts);
88

99
if(!pts) return;
1010

src/traces/violin/hover.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,10 @@ var Axes = require('../../plots/cartesian/axes');
55
var boxHoverPoints = require('../box/hover');
66
var helpers = require('./helpers');
77

8-
module.exports = function hoverPoints(pointData, xval, yval, hovermode, hoverLayer) {
8+
module.exports = function hoverPoints(pointData, xval, yval, hovermode, opts) {
9+
if(!opts) opts = {};
10+
var hoverLayer = opts.hoverLayer;
11+
912
var cd = pointData.cd;
1013
var trace = cd[0].trace;
1114
var hoveron = trace.hoveron;

0 commit comments

Comments
 (0)