From d659b1c189d04478e610aa641d459eae17001d37 Mon Sep 17 00:00:00 2001 From: Hammad Khan Date: Tue, 21 Sep 2021 22:58:04 -0400 Subject: [PATCH 1/2] Add config key --- CHANGELOG.md | 2 ++ R/dash.R | 1 + 2 files changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 95ff4705..e8eacf13 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,8 @@ This project adheres to [Semantic Versioning](http://semver.org/). ### Fixed - Minor fix for favicon issue continued from [#240](https://github.com/plotly/dashr/pull/240) (for more details, see [#243](https://github.com/plotly/dashR/pull/243#issuecomment-842813526)). +- Minor fix to enable `suppress_callback_exceptions` configuration option when creating a Dash app. [#268](https://github.com/plotly/dashr/pull/268) + ## [0.9.1] - 2020-11-16 ### Fixed diff --git a/R/dash.R b/R/dash.R index 8dcba7be..59a44f1a 100644 --- a/R/dash.R +++ b/R/dash.R @@ -107,6 +107,7 @@ Dash <- R6::R6Class( self$config$external_stylesheets <- external_stylesheets self$config$show_undo_redo <- show_undo_redo self$config$update_title <- update_title + self$config$suppress_callback_exceptions <- suppress_callback_exceptions # ensure attributes are valid, if using a list within a list, elements are all named assertValidExternals(scripts = external_scripts, stylesheets = external_stylesheets) From d6478ab45040cd7d08b8edec25a49fdf1bc6a2e6 Mon Sep 17 00:00:00 2001 From: Hammad Khan Date: Tue, 21 Sep 2021 23:52:07 -0400 Subject: [PATCH 2/2] Fixing CI --- .circleci/config.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 4a82f472..fdecb487 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -36,14 +36,10 @@ jobs: - run: name: ⚙️ Integration tests command: | - curl --proto '=https' --tlsv1.2 -sSf -o rust-init.sh https://sh.rustup.rs - chmod ugo+x rust-init.sh - ./rust-init.sh -y python -m venv venv . venv/bin/activate + pip install --upgrade pip git clone --depth 1 https://github.com/plotly/dash.git dash-main - export PATH=$PATH:/home/circleci/.local/bin/:/home/circleci/.cargo/bin - export RUSTC_BOOTSTRAP=1 cd dash-main && pip install -e .[dev,testing] --progress-bar off && cd .. cd dash-main/\@plotly/dash-generator-test-component-nested && npm ci && npm run build && sudo R CMD INSTALL . && cd ../../.. cd dash-main/\@plotly/dash-generator-test-component-standard && npm ci && npm run build && sudo R CMD INSTALL . && cd ../../..