Skip to content

Dash for R v0.8.0 #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Oct 28, 2020
Merged

Dash for R v0.8.0 #235

merged 29 commits into from
Oct 28, 2020

Conversation

rpkyle
Copy link
Contributor

@rpkyle rpkyle commented Oct 26, 2020 •
edited
Loading

[0.8.0] - 2020-10-27

Fixed

  • Usage of glue has been corrected to address #232 via #233.

Added

  • Pattern-matching IDs and callbacks. Component IDs can be lists, and callbacks can reference patterns of components, using three different wildcards: ALL, MATCH, and ALLSMALLER. This lets you create components on demand, and have callbacks respond to any and all of them. To help with this, app$callback_context gets three new entries: outputs_list, inputs_list, and states_list, which contain all the ids, properties, and except for the outputs, the property values from all matched components. #228
  • New and improved callback graph in the debug menu. Now based on Cytoscape for much more interactivity, plus callback profiling including number of calls, fine-grained time information, bytes sent and received, and more. You can even add custom timing information on the server with callback_context.record_timing(name, duration, description) #224
  • Support for setting attributes on external_scripts and external_stylesheets, and validation for the parameters passed (attributes are verified, and elements that are lists themselves must be named). #226
  • Dash for R now supports user-defined routes and redirects via the app$server_route and app$redirect methods. #225

Changed

  • dash-renderer updated to v1.8.2

Ryan Patrick Kyle and others added 14 commits August 3, 2020 13:27
contribute test script
e5b0cfe
remove version updating in DESCRIPTION
a242d49
@rpkyle @HammadTheOne
fix EOL
f1b81d6 
Co-authored-by: HammadTheOne <[email protected]>
@rpkyle
Merge pull request #222 from plotly/212-untangle-dashr-build
4d234cb 
Relocate metadata fixup logic from config.yml to R script
@rpkyle
Add support for user-defined server routes (#225)
4e4ccb1
@rpkyle
Provide support for script and stylesheet attributes (#226)
5bd1bbb
@rpkyle
Authenticate on pulls from Docker Hub (#231)
3f862f9
@rpkyle
Add support for callback graph improvements and timing (#224)
3a3ee2f
@rpkyle
Update CHANGELOG.md
766e3a8
@HammadTheOne @rpkyle @nicolaskruchten
189 - Add Pattern Matching Callbacks for Dash R (#228)
3b54773 
* Testing initial implementation

* More testing

* Callback Context Updates

* Updating callback context logic

* Fixing callback returns

* Adding callback args conditional

* Cleanup and additional changes to callback value conditionals

* Comment cleanup

* Added PMC callback validation, removed unnecessary code

* Update R/dependencies.R

Co-authored-by: Ryan Patrick Kyle <[email protected]>

* Update R/dependencies.R

Co-authored-by: Ryan Patrick Kyle <[email protected]>

* Update R/dependencies.R

Co-authored-by: Ryan Patrick Kyle <[email protected]>

* Update R/dependencies.R

Co-authored-by: Ryan Patrick Kyle <[email protected]>

* Added build to gitignore

* Updated dependencies.R

* Update boilerplate docs and add wildcard symbols

* Drying up validation code and applying symbol logic

* Update test to use symbols

* Cleaned up code and added allsmaller test example

* Cleaning up redundant code

* Update FUNDING.yml

* Updated callback_args logic and example

* Adding basic unittests, updated validation

* Fixed response for MATCH callbacks

* Added integration test and updated examples for docs

* Added additional integration test

* Formatting and cleanup

* update docs

* Update to-do app

* Add comments to examples

* Change empy vector to character type.

Co-authored-by: Ryan Patrick Kyle <[email protected]>

* Update boilerplate text.

Co-authored-by: Ryan Patrick Kyle <[email protected]>

* Update tests/integration/callbacks/test_pattern_matching.py

Co-authored-by: Ryan Patrick Kyle <[email protected]>

* Update tests/integration/callbacks/test_pattern_matching.py

Co-authored-by: Ryan Patrick Kyle <[email protected]>

* Update tests/integration/callbacks/test_pattern_matching.py

Co-authored-by: Ryan Patrick Kyle <[email protected]>

* Update tests/integration/callbacks/test_pattern_matching.py

Co-authored-by: Ryan Patrick Kyle <[email protected]>

* Update tests/integration/callbacks/test_pattern_matching.py

Co-authored-by: Ryan Patrick Kyle <[email protected]>

* Update tests/testthat/test-wildcards.R

Co-authored-by: Ryan Patrick Kyle <[email protected]>

* Update wildcards_test.R

Co-authored-by: Ryan Patrick Kyle <[email protected]>

* Update wildcards_test.R

Co-authored-by: Ryan Patrick Kyle <[email protected]>

* Update wildcards_test.R

Co-authored-by: Ryan Patrick Kyle <[email protected]>

* Update wildcards_test.R

Co-authored-by: Ryan Patrick Kyle <[email protected]>

* Update wildcards_test.R

Co-authored-by: Ryan Patrick Kyle <[email protected]>

* Update wildcards_test.R

Co-authored-by: Ryan Patrick Kyle <[email protected]>

* Update wildcards_test.R

Co-authored-by: Ryan Patrick Kyle <[email protected]>

* Update wildcards_test.R

Co-authored-by: Ryan Patrick Kyle <[email protected]>

* Removed triple colon syntax

* Use seq_along and remove unnecessary unittest

* Update CHANGELOG.md

* Update CHANGELOG.md

* Add support for arbitrary and sorted keys

* Whitespace deleted

* Added integration tests

* Fixing test output

* Fixing flakiness

* Update test_pattern_matching.py

* Update test_pattern_matching.py

* Updating boilerplate text and test with generalized keys

* Minor test fixes

Co-authored-by: Ryan Patrick Kyle <[email protected]>
Co-authored-by: Nicolas Kruchten <[email protected]>
Co-authored-by: rpkyle <[email protected]>
@HammadTheOne
Fixing Null error with glue::glue interpolation (#233)
03ed383 
* Fixing NULL error with glue interpolation

* Update utils.R

* Update utils.R
@rpkyle
Update CHANGELOG.md
5b31534
@rpkyle
Update dash-renderer to v1.8.2 (#234)
2fdd157 
* bump dash-renderer to v1.8.2

* Update CHANGELOG.md

* add note about update to dash-renderer

* Fixing flaky test
bump package version to v0.8.0
bb9fc6a
@rpkyle rpkyle requested a review from HammadTheOne October 26, 2020 19:45
@rpkyle rpkyle self-assigned this Oct 26, 2020
HammadTheOne
HammadTheOne reviewed Oct 26, 2020
View reviewed changes
HammadTheOne
HammadTheOne reviewed Oct 26, 2020
View reviewed changes
HammadTheOne
HammadTheOne reviewed Oct 26, 2020
View reviewed changes
HammadTheOne
HammadTheOne approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@HammadTheOne HammadTheOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

A couple of very minor suggestions, but other than that it looks great to me.

HammadTheOne
HammadTheOne reviewed Oct 27, 2020
View reviewed changes
HammadTheOne
HammadTheOne reviewed Oct 27, 2020
View reviewed changes
HammadTheOne
HammadTheOne reviewed Oct 27, 2020
View reviewed changes
@rpkyle rpkyle merged commit add8dd3 into master Oct 28, 2020
@rpkyle rpkyle mentioned this pull request Oct 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadTheOne HammadTheOne HammadTheOne approved these changes

Assignees

@rpkyle rpkyle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpkyle @HammadTheOne