Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

Commit a1cae86

Browse files
jbamptonjbampton
committed
đź’„ Spice up the CircleCI config file. Remove unneeded quotes from YAML keys.
Remove duplicate entry from .gitignore. Fix case of YAML value - Run.
1 parent fea3c9f commit a1cae86

File tree

2 files changed

+36
-38
lines changed

2 files changed

+36
-38
lines changed

‎.circleci/config.yml

Lines changed: 36 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
version: 2
22

33
jobs:
4-
"server-test":
4+
server-test:
55
docker:
66
- image: circleci/python:3.6-node-browsers
77
- image: cypress/base:10
@@ -11,10 +11,10 @@ jobs:
1111
- restore_cache:
1212
key: deps1-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}-{{ checksum ".circleci/config.yml" }}
1313
- run:
14-
name: Install npm packages
14+
name: 🏗️ Install npm packages
1515
command: npm ci
1616
- run:
17-
name: Cypress Install
17+
name: 🏗️ Cypress Install
1818
command: |
1919
$(npm bin)/cypress install
2020
@@ -25,7 +25,7 @@ jobs:
2525
- /home/circleci/.cache/Cypress
2626

2727
- run:
28-
name: Install requirements
28+
name: 🏗️ Install requirements
2929
command: |
3030
sudo pip install --upgrade virtualenv
3131
python -m venv venv || virtualenv venv
@@ -35,21 +35,21 @@ jobs:
3535
pip install -e ./dash-main[dev] --quiet
3636
3737
- run:
38-
name: Build
38+
name: 🏗️ Build
3939
command: |
4040
. venv/bin/activate
4141
npm run private::build:js-test
4242
npm run private::build:py
4343
pip install -e .
4444
4545
- run:
46-
name: Run tests
46+
name: 🧪 Run tests
4747
command: |
4848
. venv/bin/activate
4949
npm run test.server
5050
5151
52-
"standalone-test":
52+
standalone-test:
5353
docker:
5454
- image: circleci/python:3.6.7-node-browsers
5555
- image: cypress/base:10
@@ -59,10 +59,10 @@ jobs:
5959
- restore_cache:
6060
key: deps1-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}-{{ checksum ".circleci/config.yml" }}
6161
- run:
62-
name: Install npm packages
62+
name: 🏗️ Install npm packages
6363
command: npm ci
6464
- run:
65-
name: Cypress Install
65+
name: 🏗️ Cypress Install
6666
command: |
6767
$(npm bin)/cypress install
6868
@@ -73,14 +73,14 @@ jobs:
7373
- /home/circleci/.cache/Cypress
7474

7575
- run:
76-
name: Run tests
76+
name: 🧪 Run tests
7777
command: |
7878
rm -rf node_modules/cypress
7979
npm i [email protected]
8080
npm run test.standalone
8181
8282
83-
"unit-test":
83+
unit-test:
8484
docker:
8585
- image: circleci/python:3.6-node-browsers
8686
- image: cypress/base:10
@@ -90,10 +90,10 @@ jobs:
9090
- restore_cache:
9191
key: deps1-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}-{{ checksum ".circleci/config.yml" }}
9292
- run:
93-
name: Install npm packages
93+
name: 🏗️ Install npm packages
9494
command: npm ci
9595
- run:
96-
name: Cypress Install
96+
name: 🏗️ Cypress Install
9797
command: |
9898
$(npm bin)/cypress install
9999
@@ -104,7 +104,7 @@ jobs:
104104
- /home/circleci/.cache/Cypress
105105

106106
- run:
107-
name: Install requirements
107+
name: 🏗️ Install requirements
108108
command: |
109109
sudo pip install --upgrade virtualenv
110110
python -m venv venv || virtualenv venv
@@ -114,14 +114,14 @@ jobs:
114114
pip install -e ./dash-main[dev] --quiet
115115
116116
- run:
117-
name: Run tests
117+
name: 🧪 Run tests
118118
command: |
119119
. venv/bin/activate
120120
npm run build
121121
npm run test.unit
122122
123123
124-
"visual-test":
124+
visual-test:
125125
docker:
126126
- image: circleci/node:10-browsers
127127

@@ -132,7 +132,7 @@ jobs:
132132
key: deps1-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}
133133

134134
- run:
135-
name: Install package.json
135+
name: 🏗️ Install package.json
136136
command: npm ci
137137

138138
- save_cache:
@@ -141,31 +141,31 @@ jobs:
141141
- node_modules
142142

143143
- run:
144-
name: Run build:js
144+
name: 🏗️ Run build:js
145145
command: npm run private::build:js
146146

147147
- run:
148-
name: Run visual tests
148+
name: 🧪 Run visual tests
149149
command: npm run test.visual
150150
- store_artifacts:
151151
path: storybook-static
152152

153-
"node":
153+
node:
154154
docker:
155155
- image: circleci/python:3.6-node
156156

157157
steps:
158158
- checkout
159159

160160
- run:
161-
name: Create virtual env
161+
name: 🔧 Create virtual env
162162
command: python -m venv || virtualenv venv
163163

164164
- restore_cache:
165165
key: deps1-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}
166166

167167
- run:
168-
name: Install package.json
168+
name: 🏗️ Install package.json
169169
command: npm ci
170170

171171
- save_cache:
@@ -174,20 +174,20 @@ jobs:
174174
- node_modules
175175

176176
- run:
177-
name: Install requirements
177+
name: 🏗️ Install requirements
178178
command: |
179179
. venv/bin/activate
180180
pip install -r dev-requirements.txt --quiet
181181
182182
- run:
183-
name: Run eslint
183+
name: 🧪 Run eslint
184184
command: |
185185
. venv/bin/activate
186186
npm run lint
187187
when: always
188188

189189

190-
"python-3.6":
190+
python-3.6:
191191
docker:
192192
- image: circleci/python:3.6-stretch-node-browsers
193193

@@ -199,12 +199,12 @@ jobs:
199199
- checkout
200200

201201
- run:
202-
name: Inject Percy Environment variables
202+
name: đź’‰ Inject Percy Environment variables
203203
command: |
204204
echo 'export PERCY_TOKEN="$PERCY_PYTHON_TOKEN_V0"' >> $BASH_ENV
205205
206206
- run:
207-
name: Install requirements
207+
name: 🏗️ Install requirements
208208
command: |
209209
sudo pip install --upgrade virtualenv
210210
python -m venv venv || virtualenv venv
@@ -213,22 +213,22 @@ jobs:
213213
npm ci
214214
215215
- run:
216-
name: Install dependencies (dash)
216+
name: 🏗️ Install dependencies (dash)
217217
command: |
218218
. venv/bin/activate
219219
git clone --depth 1 [email protected]:plotly/dash.git dash-main
220220
pip install -e ./dash-main[dev,testing] --quiet
221221
cd dash-main/dash-renderer && npm run build && pip install -e . && cd ../..
222222
223223
- run:
224-
name: Install test requirements
224+
name: 🏗️ Install test requirements
225225
command: |
226226
. venv/bin/activate
227227
npm run build
228228
pip install -e .
229229
230230
- run:
231-
name: ⚙️ run integration test
231+
name: ⚙️ Run integration test
232232
command: |
233233
. venv/bin/activate
234234
pytest --junitxml=test-reports/dash.xml tests/integration
@@ -245,9 +245,9 @@ workflows:
245245
version: 2
246246
build:
247247
jobs:
248-
- "python-3.6"
249-
- "node"
250-
- "server-test"
251-
- "standalone-test"
252-
- "unit-test"
253-
- "visual-test"
248+
- python-3.6
249+
- node
250+
- server-test
251+
- standalone-test
252+
- unit-test
253+
- visual-test

‎.gitignore

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,5 +42,3 @@ lib
4242
dist
4343
*__pycache__*
4444
__pycache__/
45-
46-
*.pyc

0 commit comments

Comments
 (0)