Skip to content

Commit c7589f6

Browse files
committed
Fix builds once again
Using esModule interop for rollup caused some packages like React to import incorrectly
1 parent b182f58 commit c7589f6

File tree

8 files changed

+29
-12
lines changed

8 files changed

+29
-12
lines changed

.changeset/calm-teeth-take.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
---
2+
"@plexinc/react-native-lightning": patch
3+
"@plexinc/react-lightning-plugin-css-transform": patch
4+
"@plexinc/react-lightning-example": patch
5+
"@plexinc/react-lightning-plugin-flexbox": patch
6+
"@repo/rollup-config": patch
7+
"@plexinc/react-lightning-storybook": patch
8+
"@plexinc/react-native-lightning-example": patch
9+
"@plexinc/react-lightning-plugin-devtools": patch
10+
"@plexinc/react-lightning-plugin-flexbox-lite": patch
11+
"@plexinc/react-lightning-plugin-reanimated": patch
12+
"@plexinc/react-lightning": patch
13+
"@plexinc/react-lightning-components": patch
14+
"@plexinc/vite-plugin-msdf-fontgen": patch
15+
"@plexinc/vite-plugin-react-native-lightning": patch
16+
"@plexinc/vite-plugin-react-reanimated-lightning": patch
17+
---
18+
19+
Fixing cjs builds pt.2

apps/react-lightning-example/src/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
createRoot as createRootLng,
66
} from '@plexinc/react-lightning';
77
import devtools from '@plexinc/react-lightning-plugin-devtools/plugin';
8-
import flexbox from '@plexinc/react-lightning-plugin-flexbox';
8+
import { plugin as flexPlugin } from '@plexinc/react-lightning-plugin-flexbox';
99
import { createRoot as createRootDom } from 'react-dom/client';
1010
import { RouterProvider, createBrowserRouter } from 'react-router-dom';
1111
import { keyMap } from './keyMap';
@@ -78,7 +78,7 @@ const options: RenderOptions = {
7878
}),
7979
],
8080
enableContextSpy: true,
81-
plugins: [flexbox(), devtools()],
81+
plugins: [flexPlugin(), devtools()],
8282
effects: {
8383
Noise: NoiseEffect,
8484
StaticAlpha: StaticAlphaEffect,

apps/storybook/src/components/StorybookDecorator.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { SdfTrFontFace } from '@lightningjs/renderer';
22
import { Canvas, type RenderOptions } from '@plexinc/react-lightning';
3-
import flexbox from '@plexinc/react-lightning-plugin-flexbox';
3+
import { plugin as flexPlugin } from '@plexinc/react-lightning-plugin-flexbox';
44
import { useMemo } from 'react';
55
import { keyMap } from '../../keyMap';
66
import { DefaultStoryHeight, DefaultStoryWidth } from '../helpers/constants';
@@ -27,7 +27,7 @@ export function StorybookDecorator({ story: Story, canvasOptions }: Props) {
2727
stage,
2828
}),
2929
],
30-
plugins: [flexbox()],
30+
plugins: [flexPlugin()],
3131
...canvasOptions,
3232
}),
3333
[canvasOptions],

packages/plugin-css-transform/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export { flattenStyles } from './utils/flattenStyles';
99
export { parseTransform } from './utils/parseTransform';
1010
export * from './types';
1111

12-
export default function plugin(): Plugin {
12+
export function plugin(): Plugin {
1313
return {
1414
transformProps(_instance, props) {
1515
if (!('style' in props)) {

packages/plugin-flexbox/src/index.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,7 @@ import { isFlexStyleProp } from './isFlexStyleProp';
1212
import type { YogaOptions } from './yoga';
1313
import Yoga, { createNode, init } from './yoga';
1414

15-
export default function flexPlugin(
16-
yogaOptions?: YogaOptions,
17-
): Plugin<LightningElement> {
15+
export function plugin(yogaOptions?: YogaOptions): Plugin<LightningElement> {
1816
let _isRenderQueued = false;
1917
let _rootElement: LightningElement | null = null;
2018
let _queueTimeout: number | null = null;

packages/react-native-lightning/src/exports/Platform.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import type { PlatformOSType } from 'react-native';
22

33
export const OS = 'web';
44
export const isTV = true;
5+
export const isPad = false;
56
export const isLightning = true;
67
export const isTesting = true;
78
export const Version = '0.1.0';

packages/react-native-lightning/src/render/AppRegistry.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ import {
33
type RenderOptions,
44
createRoot,
55
} from '@plexinc/react-lightning';
6-
import cssPlugin from '@plexinc/react-lightning-plugin-css-transform';
7-
import flexboxPlugin from '@plexinc/react-lightning-plugin-flexbox';
6+
import { plugin as cssPlugin } from '@plexinc/react-lightning-plugin-css-transform';
7+
import { plugin as flexboxPlugin } from '@plexinc/react-lightning-plugin-flexbox';
88
import type { ComponentProvider } from 'react-native';
99
import { cssClassNameTransformPlugin } from '../plugins/cssClassNameTransformPlugin';
1010
import { domPolyfillsPlugin } from '../plugins/domPolyfillsPlugin';

packages/rollup-config/index.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import swc from 'rollup-plugin-swc3';
99
export default ({
1010
useClient = false,
1111
preserveModules = false,
12-
outputExports = 'named',
12+
outputExports = 'auto',
1313
input = ['./src/index.ts'],
1414
external = [],
1515
options = {},
@@ -37,7 +37,6 @@ export default ({
3737
},
3838
format: 'cjs',
3939
exports: outputExports,
40-
interop: 'esModule',
4140
},
4241
],
4342
external,

0 commit comments

Comments
 (0)