TECH Satisfy linters

Author: sibprogrammer

src/Api/AbstractStruct.php

@@ -24,7 +24,7 @@ public function __set(string $property, $value)
      *
      * @throws \Exception
      */
-    protected function initScalarProperties($apiResponse, array $properties): void
+    protected function initScalarProperties(\SimpleXMLElement $apiResponse, array $properties): void
     {
         foreach ($properties as $property) {
             if (is_array($property)) {

src/Api/Operator/DatabaseServer.php

@@ -60,9 +60,11 @@ private function getBy($field = null, $value = null): array
             if (!$xmlResult) {
                 continue;
             }
-            $item = new Struct\Info($xmlResult->data);
-            $item->id = (int) $xmlResult->id;
-            $items[] = $item;
+            if (!is_null($xmlResult->data)) {
+                $item = new Struct\Info($xmlResult->data);
+                $item->id = (int) $xmlResult->id;
+                $items[] = $item;
+            }
         }
 
         return $items;

src/Api/Operator/Dns.php

@@ -82,9 +82,11 @@ public function getAll(string $field, $value): array
             if (!$xmlResult) {
                 continue;
             }
-            $item = new Struct\Info($xmlResult->data);
-            $item->id = (int) $xmlResult->id;
-            $items[] = $item;
+            if (!is_null($xmlResult->data)) {
+                $item = new Struct\Info($xmlResult->data);
+                $item->id = (int) $xmlResult->id;
+                $items[] = $item;
+            }
         }
 
         return $items;

src/Api/Operator/DnsTemplate.php

@@ -63,9 +63,11 @@ public function getAll($field = null, $value = null): array
             if (!$xmlResult) {
                 continue;
             }
-            $item = new Struct\Info($xmlResult->data);
-            $item->id = (int) $xmlResult->id;
-            $items[] = $item;
+            if (!is_null($xmlResult->data)) {
+                $item = new Struct\Info($xmlResult->data);
+                $item->id = (int) $xmlResult->id;
+                $items[] = $item;
+            }
         }
 
         return $items;

src/Api/Operator/EventLog.php

@@ -17,7 +17,7 @@ public function get(): array
         $records = [];
         $response = $this->request('get');
 
-        foreach ($response->event as $eventInfo) {
+        foreach ($response->event ?? [] as $eventInfo) {
             $records[] = new Struct\Event($eventInfo);
         }
 
@@ -32,7 +32,7 @@ public function getDetailedLog(): array
         $records = [];
         $response = $this->request('get_events');
 
-        foreach ($response->event as $eventInfo) {
+        foreach ($response->event ?? [] as $eventInfo) {
             $records[] = new Struct\DetailedEvent($eventInfo);
         }
 

src/Api/Operator/Ip.php

@@ -17,7 +17,7 @@ public function get(): array
         $packet->addChild($this->wrapperTag)->addChild('get');
         $response = $this->client->request($packet);
 
-        foreach ($response->addresses->ip_info as $ipInfo) {
+        foreach ($response->addresses->ip_info ?? [] as $ipInfo) {
             $ips[] = new Struct\Info($ipInfo);
         }
 

src/Api/Operator/Locale.php

@@ -24,8 +24,10 @@ public function get($id = null)
 
         $response = $this->client->request($packet, \PleskX\Api\Client::RESPONSE_FULL);
 
-        foreach ($response->locale->get->result as $localeInfo) {
-            $locales[(string) $localeInfo->info->id] = new Struct\Info($localeInfo->info);
+        foreach ($response->locale->get->result ?? [] as $localeInfo) {
+            if (!is_null($localeInfo->info)) {
+                $locales[(string) $localeInfo->info->id] = new Struct\Info($localeInfo->info);
+            }
         }
 
         return !is_null($id) ? reset($locales) : $locales;

src/Api/Operator/Mail.php

@@ -22,11 +22,13 @@ public function create(string $name, int $siteId, bool $mailbox = false, string
             $mailname->addChild('mailbox')->addChild('enabled', 'true');
         }
         if (!empty($password)) {
+            /** @psalm-suppress UndefinedPropertyAssignment */
             $mailname->addChild('password')->value = $password;
         }
 
         $response = $this->client->request($packet);
 
+        /** @psalm-suppress PossiblyNullArgument */
         return new Struct\Info($response->mailname);
     }
 

src/Api/Operator/ProtectedDirectory.php

@@ -73,6 +73,7 @@ public function getAll(string $field, $value): array
      * @param string $password
      *
      * @return Struct\UserInfo
+     * @psalm-suppress UndefinedPropertyAssignment
      */
     public function addUser($protectedDirectory, $login, $password)
     {

src/Api/Operator/Server.php

@@ -14,6 +14,7 @@ public function getProtos(): array
         $packet->addChild($this->wrapperTag)->addChild('get_protos');
         $response = $this->client->request($packet);
 
+        /** @psalm-suppress PossiblyNullPropertyFetch */
         return (array) $response->protos->proto;
     }
 
@@ -37,7 +38,7 @@ public function getKeyInfo(): array
         $keyInfo = [];
         $keyInfoXml = $this->getInfo('key');
 
-        foreach ($keyInfoXml->property as $property) {
+        foreach ($keyInfoXml->property ?? [] as $property) {
             $keyInfo[(string) $property->name] = (string) $property->value;
         }
 
@@ -49,7 +50,7 @@ public function getComponents(): array
         $components = [];
         $componentsXml = $this->getInfo('components');
 
-        foreach ($componentsXml->component as $component) {
+        foreach ($componentsXml->component ?? [] as $component) {
             $components[(string) $component->name] = (string) $component->version;
         }
 
@@ -61,7 +62,7 @@ public function getServiceStates(): array
         $states = [];
         $statesXml = $this->getInfo('services_state');
 
-        foreach ($statesXml->srv as $service) {
+        foreach ($statesXml->srv ?? [] as $service) {
             $states[(string) $service->id] = [
                 'id' => (string) $service->id,
                 'title' => (string) $service->title,
@@ -82,7 +83,7 @@ public function getShells(): array
         $shells = [];
         $shellsXml = $this->getInfo('shells');
 
-        foreach ($shellsXml->shell as $shell) {
+        foreach ($shellsXml->shell ?? [] as $shell) {
             $shells[(string) $shell->name] = (string) $shell->path;
         }
 
@@ -106,7 +107,7 @@ public function getSiteIsolationConfig(): array
         $config = [];
         $configXml = $this->getInfo('site-isolation-config');
 
-        foreach ($configXml->property as $property) {
+        foreach ($configXml->property ?? [] as $property) {
             $config[(string) $property->name] = (string) $property->value;
         }