More impossible-check eq and notEq tests, target next PHPStan version

Author: herndlm

composer.json

@@ -7,7 +7,7 @@
 	],
 	"require": {
 		"php": "^7.1 || ^8.0",
-		"phpstan/phpstan": "^1.4.8"
+		"phpstan/phpstan": "^1.4.9"
 	},
 	"require-dev": {
 		"nikic/php-parser": "^4.13.0",

tests/Type/WebMozartAssert/ImpossibleCheckTypeMethodCallRuleTest.php

@@ -59,16 +59,68 @@ public function testEqNotEq(): void
 				12,
 			],
 			[
-				'Call to static method Webmozart\Assert\Assert::eq() with stdClass and stdClass will always evaluate to true.',
-				30,
+				'Call to static method Webmozart\Assert\Assert::eq() with 1 and \'1\' will always evaluate to true.',
+				34,
+			],
+			[
+				'Call to static method Webmozart\Assert\Assert::notEq() with 1 and \'1\' will always evaluate to false.',
+				35,
+			],
+			[
+				'Call to static method Webmozart\Assert\Assert::eq() with 1 and true will always evaluate to true.',
+				36,
+			],
+			[
+				'Call to static method Webmozart\Assert\Assert::notEq() with 1 and true will always evaluate to false.',
+				37,
+			],
+			[
+				'Call to static method Webmozart\Assert\Assert::eq() with \'php\' and true will always evaluate to true.',
+				38,
+			],
+			[
+				'Call to static method Webmozart\Assert\Assert::notEq() with \'php\' and true will always evaluate to false.',
+				39,
+			],
+			[
+				'Call to static method Webmozart\Assert\Assert::eq() with \'\' and false will always evaluate to true.',
+				40,
+			],
+			[
+				'Call to static method Webmozart\Assert\Assert::notEq() with \'\' and false will always evaluate to false.',
+				41,
+			],
+			[
+				'Call to static method Webmozart\Assert\Assert::eq() with 1 and 1 will always evaluate to true.',
+				43,
+			],
+			[
+				'Call to static method Webmozart\Assert\Assert::notEq() with 1 and 1 will always evaluate to false.',
+				44,
+			],
+			[
+				'Call to static method Webmozart\Assert\Assert::eq() with true and true will always evaluate to true.',
+				45,
+			],
+			[
+				'Call to static method Webmozart\Assert\Assert::notEq() with true and true will always evaluate to false.',
+				46,
+			],
+			[
+				'Call to static method Webmozart\Assert\Assert::eq() with \'php\' and \'php\' will always evaluate to true.',
+				47,
+			],
+			[
+				'Call to static method Webmozart\Assert\Assert::notEq() with \'php\' and \'php\' will always evaluate to false.',
+				48,
 			],
 			[
 				'Call to static method Webmozart\Assert\Assert::eq() with stdClass and null will always evaluate to false.',
-				33,
+				58,
 			],
 			[
 				'Call to static method Webmozart\Assert\Assert::notEq() with stdClass and null will always evaluate to true.',
-				34,
+				59,
 			],
 		]);
 	}

tests/Type/WebMozartAssert/data/impossible-check-eq-not-eq.php

@@ -21,17 +21,42 @@ function instancesOfTheSameTypeAreNotIdenticalButCouldBeEqual(stdClass $a, stdCl
 	Assert::notEq(createStdClass(), createStdClass());
 }
 
-function instancesOfDifferentTypesAreNeverEqual(stdClass $a, DateTimeInterface $b, stdClass $c, DateTimeInterface $d, stdClass $e, stdClass $f, stdClass $g, stdClass $h): void
+function looseVariableComparisonsAreNotSupported(stdClass $a, DateTimeInterface $b, stdClass $c, DateTimeInterface $d, string $e, int $f, string $g, int $h): void
 {
-	// These don't report anything as PHPStan doesn't currently support loose comparison with ==
 	Assert::eq($a, $b);
 	Assert::notEq($c, $d);
+	Assert::eq($e, $f);
+	Assert::notEq($g, $h);
+}
+
+function constantComparisons(): void
+{
+	Assert::eq(1, '1'); // will always evaluate to true
+	Assert::notEq(1, '1'); // will always evaluate to false
+	Assert::eq(1, true); // will always evaluate to true
+	Assert::notEq(1, true); // will always evaluate to false
+	Assert::eq('php', true); // will always evaluate to true
+	Assert::notEq('php', true); // will always evaluate to false
+	Assert::eq('', false); // will always evaluate to true
+	Assert::notEq('', false); // will always evaluate to false
 
-	Assert::eq($e, new stdClass()); // will always evaluate to true, should not report anything
-	Assert::notEq($f, new stdClass());
+	Assert::eq(1, 1); // will always evaluate to true
+	Assert::notEq(1, 1); // will always evaluate to false
+	Assert::eq(true, true); // will always evaluate to true
+	Assert::notEq(true, true); // will always evaluate to false
+	Assert::eq('php', 'php'); // will always evaluate to true
+	Assert::notEq('php', 'php'); // will always evaluate to false
+}
+
+function instancesOfDifferentTypesAreNeverEqual(stdClass $a, stdClass $b, stdClass $c, stdClass $d, stdClass $e, stdClass $f): void
+{
+	Assert::eq($a, new stdClass());
+	Assert::eq($b, createStdClass());
+	Assert::notEq($c, new stdClass());
+	Assert::notEq($d, createStdClass());
 
-	Assert::eq($g, null); // will always evaluate to false
-	Assert::notEq($h, null); // will always evaluate to true
+	Assert::eq($e, null); // will always evaluate to false
+	Assert::notEq($f, null); // will always evaluate to true
 }
 
 function createStdClass(): stdClass