remove fake params from setcookie/setrawcookie

Author: schlndh

resources/functionMap.php

@@ -10424,15 +10424,15 @@
 'set_include_path' => ['string|false', 'new_include_path'=>'string'],
 'set_magic_quotes_runtime' => ['bool', 'new_setting'=>'bool'],
 'set_time_limit' => ['bool', 'seconds'=>'int'],
-'setcookie' => ['bool', 'name'=>'string', 'value='=>'string', 'expires='=>'int', 'path='=>'string', 'domain='=>'string', 'secure='=>'bool', 'httponly='=>'bool', 'samesite='=>'\'None\'|\'Lax\'|\'Strict\'|\'none\'|\'lax\'|\'strict\'', 'url_encode='=>'int'],
-'setcookie\'1' => ['bool', 'name'=>'string', 'value='=>'string', 'options='=>'array{ expires?:int, path?:string, domain?:string, secure?:bool, httponly?:bool, samesite?:\'None\'|\'Lax\'|\'Strict\'|\'none\'|\'lax\'|\'strict\', url_encode?:int}'],
+'setcookie' => ['bool', 'name'=>'string', 'value='=>'string', 'expires='=>'int', 'path='=>'string', 'domain='=>'string', 'secure='=>'bool', 'httponly='=>'bool'],
+'setcookie\'1' => ['bool', 'name'=>'string', 'value='=>'string', 'options='=>'array{ expires?:int, path?:string, domain?:string, secure?:bool, httponly?:bool, samesite?:\'None\'|\'Lax\'|\'Strict\'|\'none\'|\'lax\'|\'strict\'}'],
 'setLeftFill' => ['void', 'red'=>'int', 'green'=>'int', 'blue'=>'int', 'a='=>'int'],
 'setLine' => ['void', 'width'=>'int', 'red'=>'int', 'green'=>'int', 'blue'=>'int', 'a='=>'int'],
 'setlocale' => ['string|false', 'category'=>'int', 'locale'=>'string|null', '...args='=>'string'],
 'setlocale\'1' => ['string|false', 'category'=>'int', 'locale'=>'?array'],
 'setproctitle' => ['void', 'title'=>'string'],
-'setrawcookie' => ['bool', 'name'=>'string', 'value='=>'string', 'expires='=>'int', 'path='=>'string', 'domain='=>'string', 'secure='=>'bool', 'httponly='=>'bool', 'samesite='=>'\'None\'|\'Lax\'|\'Strict\'|\'none\'|\'lax\'|\'strict\'', 'url_encode='=>'int'],
-'setrawcookie\'1' => ['bool', 'name'=>'string', 'value='=>'string', 'options='=>'array{ expires?:int, path?:string, domain?:string, secure?:bool, httponly?:bool, samesite?:\'None\'|\'Lax\'|\'Strict\'|\'none\'|\'lax\'|\'strict\', url_encode?:int}'],
+'setrawcookie' => ['bool', 'name'=>'string', 'value='=>'string', 'expires='=>'int', 'path='=>'string', 'domain='=>'string', 'secure='=>'bool', 'httponly='=>'bool'],
+'setrawcookie\'1' => ['bool', 'name'=>'string', 'value='=>'string', 'options='=>'array{ expires?:int, path?:string, domain?:string, secure?:bool, httponly?:bool, samesite?:\'None\'|\'Lax\'|\'Strict\'|\'none\'|\'lax\'|\'strict\'}'],
 'setRightFill' => ['void', 'red'=>'int', 'green'=>'int', 'blue'=>'int', 'a='=>'int'],
 'setthreadtitle' => ['bool', 'title'=>'string'],
 'settype' => ['bool', '&rw_var'=>'mixed', 'type'=>'string'],

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -1558,4 +1558,30 @@ public function testCallToArrayFilterWithNullCallback(): void
 		$this->analyse([__DIR__ . '/data/array_filter_null_callback.php'], []);
 	}
 
+	public function testBug10171(): void
+	{
+		if (PHP_VERSION_ID < 80000) {
+			$this->markTestSkipped('Test requires PHP 8.0');
+		}
+
+		$this->analyse([__DIR__ . '/data/bug-10171.php'], [
+			[
+				'Unknown parameter $samesite in call to function setcookie.',
+				12,
+			],
+			[
+				'Function setcookie invoked with 9 parameters, 1-7 required.',
+				13,
+			],
+			[
+				'Unknown parameter $samesite in call to function setrawcookie.',
+				25,
+			],
+			[
+				'Function setrawcookie invoked with 9 parameters, 1-7 required.',
+				26,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Functions/data/bug-10171.php

@@ -0,0 +1,36 @@
+<?php declare(strict_types=1); // lint >= 8.0
+
+namespace Bug10171;
+
+setcookie("name", "value", 0, "/", secure: true, httponly: true);
+setcookie('name', expires_or_options: ['samesite' => 'lax']);
+
+setrawcookie("name", "value", 0, "/", secure: true, httponly: true);
+setrawcookie('name', expires_or_options: ['samesite' => 'lax']);
+
+// Wrong
+setcookie('name', samesite: 'lax');
+setcookie(
+	'aaa',
+	'bbb',
+	10,
+	'/',
+	'example.com',
+	true,
+	false,
+	'lax',
+	1,
+);
+
+setrawcookie('name', samesite: 'lax');
+setrawcookie(
+	'aaa',
+	'bbb',
+	10,
+	'/',
+	'example.com',
+	true,
+	false,
+	'lax',
+	1,
+);