stdClass does not have __get method

Author: ondrejmirtes

conf/config.neon

@@ -720,7 +720,6 @@ services:
 		arguments:
 			parser: @defaultAnalysisParser
 			inferPrivatePropertyTypeFromConstructor: %inferPrivatePropertyTypeFromConstructor%
-			universalObjectCratesClasses: %universalObjectCratesClasses%
 
 	-
 		implement: PHPStan\Reflection\Php\PhpMethodReflectionFactory

src/Reflection/Php/FakeBuiltinMethodReflection.php

@@ -98,7 +98,6 @@ public function __construct(
 		private ReflectionProvider\ReflectionProviderProvider $reflectionProviderProvider,
 		private FileTypeMapper $fileTypeMapper,
 		private bool $inferPrivatePropertyTypeFromConstructor,
-		private array $universalObjectCratesClasses,
 	)
 	{
 	}
@@ -398,20 +397,7 @@ public function getMethod(ClassReflection $classReflection, string $methodName):
 
 	public function hasNativeMethod(ClassReflection $classReflection, string $methodName): bool
 	{
-		$hasMethod = $this->hasMethod($classReflection, $methodName);
-		if ($hasMethod) {
-			return true;
-		}
-
-		if ($methodName === '__get' && UniversalObjectCratesClassReflectionExtension::isUniversalObjectCrate(
-			$this->reflectionProviderProvider->getReflectionProvider(),
-			$this->universalObjectCratesClasses,
-			$classReflection,
-		)) {
-			return true;
-		}
-
-		return false;
+		return $this->hasMethod($classReflection, $methodName);
 	}
 
 	public function getNativeMethod(ClassReflection $classReflection, string $methodName): ExtendedMethodReflection
@@ -420,27 +406,14 @@ public function getNativeMethod(ClassReflection $classReflection, string $method
 			return $this->nativeMethods[$classReflection->getCacheKey()][$methodName];
 		}
 
-		if ($classReflection->getNativeReflection()->hasMethod($methodName)) {
-			$nativeMethodReflection = new NativeBuiltinMethodReflection(
-				$classReflection->getNativeReflection()->getMethod($methodName),
-			);
-		} else {
-			if (
-				$methodName !== '__get'
-				|| !UniversalObjectCratesClassReflectionExtension::isUniversalObjectCrate(
-					$this->reflectionProviderProvider->getReflectionProvider(),
-					$this->universalObjectCratesClasses,
-					$classReflection,
-				)) {
-				throw new ShouldNotHappenException();
-			}
-
-			$nativeMethodReflection = new FakeBuiltinMethodReflection(
-				$methodName,
-				$classReflection->getNativeReflection(),
-			);
+		if (!$classReflection->getNativeReflection()->hasMethod($methodName)) {
+			throw new ShouldNotHappenException();
 		}
 
+		$nativeMethodReflection = new NativeBuiltinMethodReflection(
+			$classReflection->getNativeReflection()->getMethod($methodName),
+		);
+
 		if (!isset($this->nativeMethods[$classReflection->getCacheKey()][$nativeMethodReflection->getName()])) {
 			$method = $this->createMethod($classReflection, $nativeMethodReflection, false);
 			$this->nativeMethods[$classReflection->getCacheKey()][$nativeMethodReflection->getName()] = $method;

src/Reflection/Php/PhpClassReflectionExtension.php

@@ -712,6 +712,21 @@ public function testBug9615(): void
 		]);
 	}
 
+	public function testBug10149(): void
+	{
+		$this->phpVersionId = PHP_VERSION_ID;
+		$errors = [];
+		if (PHP_VERSION_ID >= 80300) {
+			$errors = [
+				[
+					'Method Bug10149\StdSat::__get() has #[\Override] attribute but does not override any method.',
+					10,
+				],
+			];
+		}
+		$this->analyse([__DIR__ . '/data/bug-10149.php'], $errors);
+	}
+
 	public function testTraits(): void
 	{
 		$errors = [];

tests/PHPStan/Rules/Methods/OverridingMethodRuleTest.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace Bug10149;
+
+trait WarnDynamicPropertyTrait
+{
+	/**
+	 * @return mixed
+	 */
+	#[\Override]
+	public function &__get(string $name)
+	{
+		return $this->{$name};
+	}
+}
+
+class StdSat extends \stdClass
+{
+	use WarnDynamicPropertyTrait;
+}