Do not create conditional expression for the same variable

Author: ondrejmirtes

src/Analyser/TypeSpecifier.php

@@ -1209,8 +1209,28 @@ private function processBooleanConditionalTypes(Scope $scope, SpecifiedTypes $le
 					$holders[$exprString] = [];
 				}
 
+				$conditions = $conditionExpressionTypes;
+				foreach ($conditions as $conditionExprString => $conditionExprTypeHolder) {
+					$conditionExpr = $conditionExprTypeHolder->getExpr();
+					if (!$conditionExpr instanceof Expr\Variable) {
+						continue;
+					}
+					if (!is_string($conditionExpr->name)) {
+						continue;
+					}
+					if ($conditionExpr->name !== $expr->name) {
+						continue;
+					}
+
+					unset($conditions[$conditionExprString]);
+				}
+
+				if (count($conditions) === 0) {
+					continue;
+				}
+
 				$holder = new ConditionalExpressionHolder(
-					$conditionExpressionTypes,
+					$conditions,
 					new ExpressionTypeHolder($expr, TypeCombinator::remove($scope->getType($expr), $type), TrinaryLogic::createYes()),
 				);
 				$holders[$exprString][$holder->getKey()] = $holder;