AppendedArrayKeyTypeRule - more precise type description

Author: ondrejmirtes

src/Rules/Arrays/AppendedArrayKeyTypeRule.php

@@ -76,10 +76,11 @@ public function processNode(\PhpParser\Node $node, Scope $scope): array
 		}
 
 		if (!$arrayType->getIterableKeyType()->isSuperTypeOf($keyType)->yes()) {
+			$verbosity = VerbosityLevel::getRecommendedLevelByType($arrayType->getIterableKeyType(), $keyType);
 			return [
 				RuleErrorBuilder::message(sprintf(
 					'Array (%s) does not accept key %s.',
-					$arrayType->describe(VerbosityLevel::typeOnly()),
+					$arrayType->describe($verbosity),
 					$keyType->describe(VerbosityLevel::value())
 				))->build(),
 			];

tests/PHPStan/Rules/Arrays/AppendedArrayKeyTypeRuleTest.php

@@ -45,6 +45,14 @@ public function testRule(): void
 				'Array (array<string, mixed>) does not accept key 1.',
 				46,
 			],
+			[
+				'Array (array<1|2|3, string>) does not accept key int.',
+				80,
+			],
+			[
+				'Array (array<1|2|3, string>) does not accept key 4.',
+				85,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Arrays/data/appended-array-key.php

@@ -68,3 +68,21 @@ public function doBar()
 	}
 
 }
+
+class MorePreciseKey
+{
+
+	/** @var array<1|2|3, string> */
+	private $test;
+
+	public function doFoo(int $i): void
+	{
+		$this->test[$i] = 'foo';
+	}
+
+	public function doBar(): void
+	{
+		$this->test[4] = 'foo';
+	}
+
+}