Get rid of getters in InternalThrowPoint

Author: ondrejmirtes

src/Analyser/Generator/ExprHandler/ClosureHelper.php

@@ -111,7 +111,7 @@ public function createClosureType(
 			);
 		}
 
-		$throwPointsForClosureType = array_map(static fn (InternalThrowPoint $throwPoint) => $throwPoint->isExplicit() ? SimpleThrowPoint::createExplicit($throwPoint->getType(), $throwPoint->canContainAnyThrowable()) : SimpleThrowPoint::createImplicit(), $throwPoints);
+		$throwPointsForClosureType = array_map(static fn (InternalThrowPoint $throwPoint) => $throwPoint->explicit ? SimpleThrowPoint::createExplicit($throwPoint->type, $throwPoint->canContainAnyThrowable) : SimpleThrowPoint::createImplicit(), $throwPoints);
 		$impurePointsForClosureType = array_map(static fn (ImpurePoint $impurePoint) => new SimpleImpurePoint($impurePoint->getIdentifier(), $impurePoint->getDescription(), $impurePoint->isCertain()), $impurePoints);
 
 		$mustUseReturnValue = TrinaryLogic::createNo();

src/Analyser/Generator/InternalThrowPoint.php

@@ -17,11 +17,11 @@ final class InternalThrowPoint
 	 * @param Node\Expr|Node\Stmt $node
 	 */
 	private function __construct(
-		private GeneratorScope $scope,
-		private Type $type,
-		private Node $node,
-		private bool $explicit,
-		private bool $canContainAnyThrowable,
+		public readonly GeneratorScope $scope,
+		public readonly Type $type,
+		public readonly Node $node,
+		public readonly bool $explicit,
+		public readonly bool $canContainAnyThrowable,
 	)
 	{
 	}
@@ -61,34 +61,6 @@ public static function createFromPublic(ThrowPoint $throwPoint): self
 		return new self($scope, $throwPoint->getType(), $throwPoint->getNode(), $throwPoint->isExplicit(), $throwPoint->canContainAnyThrowable());
 	}
 
-	public function getScope(): GeneratorScope
-	{
-		return $this->scope;
-	}
-
-	public function getType(): Type
-	{
-		return $this->type;
-	}
-
-	/**
-	 * @return Node\Expr|Node\Stmt
-	 */
-	public function getNode()
-	{
-		return $this->node;
-	}
-
-	public function isExplicit(): bool
-	{
-		return $this->explicit;
-	}
-
-	public function canContainAnyThrowable(): bool
-	{
-		return $this->canContainAnyThrowable;
-	}
-
 	public function subtractCatchType(Type $catchType): self
 	{
 		return new self($this->scope, TypeCombinator::remove($this->type, $catchType), $this->node, $this->explicit, $this->canContainAnyThrowable);

src/Analyser/Generator/NodeHandler/ArgsHandler.php

@@ -217,7 +217,7 @@ public function processArgs(
 				yield from $closureResultGen;
 				[$closureResult] = $closureResultGen->getReturn();
 				if ($callCallbackImmediately) {
-					$throwPoints = array_merge($throwPoints, array_map(static fn (InternalThrowPoint $throwPoint) => $throwPoint->isExplicit() ? InternalThrowPoint::createExplicit($scope, $throwPoint->getType(), $arg->value, $throwPoint->canContainAnyThrowable()) : InternalThrowPoint::createImplicit($scope, $arg->value), $closureResult->throwPoints));
+					$throwPoints = array_merge($throwPoints, array_map(static fn (InternalThrowPoint $throwPoint) => $throwPoint->explicit ? InternalThrowPoint::createExplicit($scope, $throwPoint->type, $arg->value, $throwPoint->canContainAnyThrowable) : InternalThrowPoint::createImplicit($scope, $arg->value), $closureResult->throwPoints));
 					$impurePoints = array_merge($impurePoints, $closureResult->impurePoints);
 					$isAlwaysTerminating = $isAlwaysTerminating || $closureResult->isAlwaysTerminating;
 				}
@@ -285,7 +285,7 @@ public function processArgs(
 				yield from $arrowFunctionResultGen;
 				$arrowFunctionResult = $arrowFunctionResultGen->getReturn();
 				if ($callCallbackImmediately) {
-					$throwPoints = array_merge($throwPoints, array_map(static fn (InternalThrowPoint $throwPoint) => $throwPoint->isExplicit() ? InternalThrowPoint::createExplicit($scope, $throwPoint->getType(), $arg->value, $throwPoint->canContainAnyThrowable()) : InternalThrowPoint::createImplicit($scope, $arg->value), $arrowFunctionResult->throwPoints));
+					$throwPoints = array_merge($throwPoints, array_map(static fn (InternalThrowPoint $throwPoint) => $throwPoint->explicit ? InternalThrowPoint::createExplicit($scope, $throwPoint->type, $arg->value, $throwPoint->canContainAnyThrowable) : InternalThrowPoint::createImplicit($scope, $arg->value), $arrowFunctionResult->throwPoints));
 					$impurePoints = array_merge($impurePoints, $arrowFunctionResult->impurePoints);
 					$isAlwaysTerminating = $isAlwaysTerminating || $arrowFunctionResult->isAlwaysTerminating;
 				}
@@ -305,7 +305,7 @@ public function processArgs(
 						if ($callCallbackImmediately) {
 							$callableThrowPoints = array_map(static fn (SimpleThrowPoint $throwPoint) => $throwPoint->isExplicit() ? InternalThrowPoint::createExplicit($scope, $throwPoint->getType(), $arg->value, $throwPoint->canContainAnyThrowable()) : InternalThrowPoint::createImplicit($scope, $arg->value), $acceptors[0]->getThrowPoints());
 							if (!$this->implicitThrows) {
-								$callableThrowPoints = array_values(array_filter($callableThrowPoints, static fn (InternalThrowPoint $throwPoint) => $throwPoint->isExplicit()));
+								$callableThrowPoints = array_values(array_filter($callableThrowPoints, static fn (InternalThrowPoint $throwPoint) => $throwPoint->explicit));
 							}
 							$throwPoints = array_merge($throwPoints, $callableThrowPoints);
 							$impurePoints = array_merge($impurePoints, array_map(static fn (SimpleImpurePoint $impurePoint) => new ImpurePoint($scope, $arg->value, $impurePoint->getIdentifier(), $impurePoint->getDescription(), $impurePoint->isCertain()), $acceptors[0]->getImpurePoints()));