Fix ClosureType::equals()

ondrejmirtes · ondrejmirtes · commit 29c35b584a94 · 2024-04-04T09:31:35.000+02:00
diff --git a/src/Type/CallableType.php b/src/Type/CallableType.php
@@ -193,7 +193,11 @@ public function isAcceptedWithReasonBy(Type $acceptingType, bool $strictTypes):
 
 	public function equals(Type $type): bool
 	{
-		return $type instanceof self;
+		if (!$type instanceof self) {
+			return false;
+		}
+
+		return $this->describe(VerbosityLevel::precise()) === $type->describe(VerbosityLevel::precise());
 	}
 
 	public function describe(VerbosityLevel $level): string
diff --git a/src/Type/ClosureType.php b/src/Type/ClosureType.php
@@ -190,7 +190,7 @@ public function equals(Type $type): bool
 			return false;
 		}
 
-		return $this->returnType->equals($type->returnType);
+		return $this->describe(VerbosityLevel::precise()) === $type->describe(VerbosityLevel::precise());
 	}
 
 	public function describe(VerbosityLevel $level): string

Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,11 @@ public function isAcceptedWithReasonBy(Type $acceptingType, bool $strictTypes):`
`193`	`193`
`194`	`194`	`public function equals(Type $type): bool`
`195`	`195`	`{`
`196`		`- return $type instanceof self;`
	`196`	`+ if (!$type instanceof self) {`
	`197`	`+ return false;`
	`198`	`+ }`
	`199`	`+`
	`200`	`+ return $this->describe(VerbosityLevel::precise()) === $type->describe(VerbosityLevel::precise());`
`197`	`201`	`}`
`198`	`202`
`199`	`203`	`public function describe(VerbosityLevel $level): string`
Original file line number	Diff line number	Diff line change
`@@ -190,7 +190,7 @@ public function equals(Type $type): bool`
`190`	`190`	`return false;`
`191`	`191`	`}`
`192`	`192`
`193`		`- return $this->returnType->equals($type->returnType);`
	`193`	`+ return $this->describe(VerbosityLevel::precise()) === $type->describe(VerbosityLevel::precise());`
`194`	`194`	`}`
`195`	`195`
`196`	`196`	`public function describe(VerbosityLevel $level): string`