Bleeding edge - OverridingPropertyRule

Author: ondrejmirtes

composer.json

@@ -21,9 +21,9 @@
 		"nette/neon": "^3.0",
 		"nette/schema": "^1.0",
 		"nette/utils": "^3.1.3",
-		"nikic/php-parser": "4.12.0",
+		"nikic/php-parser": "dev-master as 4.12.0",
 		"ondram/ci-detector": "^3.4.0",
-		"ondrejmirtes/better-reflection": "4.3.64",
+		"ondrejmirtes/better-reflection": "4.3.65",
 		"phpstan/php-8-stubs": "^0.1.22",
 		"phpstan/phpdoc-parser": "^0.5.5",
 		"react/child-process": "^0.6.1",

composer.lock

@@ -26,5 +26,6 @@ parameters:
 		finalByPhpDocTag: true
 		classConstants: true
 		privateStaticCall: true
+		overridingProperty: true
 	stubFiles:
 		- ../stubs/arrayFunctions.stub

conf/bleedingEdge.neon

@@ -29,6 +29,8 @@ conditionalTags:
 		phpstan.rules.rule: %featureToggles.fileWhitespace%
 	PHPStan\Rules\Properties\UninitializedPropertyRule:
 		phpstan.rules.rule: %checkUninitializedProperties%
+	PHPStan\Rules\Properties\OverridingPropertyRule:
+		phpstan.rules.rule: %featureToggles.overridingProperty%
 
 parametersSchema:
 	missingClosureNativeReturnCheckObjectTypehint: bool()
@@ -213,6 +215,11 @@ services:
 			checkClassCaseSensitivity: %checkClassCaseSensitivity%
 			checkThisOnly: %checkThisOnly%
 
+	-
+		class: PHPStan\Rules\Properties\OverridingPropertyRule
+		arguments:
+			checkPhpDocMethodSignatures: %checkPhpDocMethodSignatures%
+
 	-
 		class: PHPStan\Rules\Properties\UninitializedPropertyRule
 		arguments:

conf/config.level0.neon

@@ -50,6 +50,7 @@ parameters:
 		finalByPhpDocTag: false
 		classConstants: false
 		privateStaticCall: false
+		overridingProperty: false
 	fileExtensions:
 		- php
 	checkAlwaysTrueCheckTypeFunctionCall: false
@@ -229,7 +230,8 @@ parametersSchema:
 		crossCheckInterfaces: bool(),
 		finalByPhpDocTag: bool(),
 		classConstants: bool(),
-		privateStaticCall: bool()
+		privateStaticCall: bool(),
+		overridingProperty: bool()
 	])
 	fileExtensions: listOf(string())
 	checkAlwaysTrueCheckTypeFunctionCall: bool()

conf/config.neon

@@ -99,6 +99,11 @@ public function isStatic(): bool
 		return (bool) ($this->flags & Class_::MODIFIER_STATIC);
 	}
 
+	public function isReadOnly(): bool
+	{
+		return (bool) ($this->flags & Class_::MODIFIER_READONLY);
+	}
+
 	/**
 	 * @return Identifier|Name|NullableType|UnionType|null
 	 */

src/Node/ClassPropertyNode.php

@@ -97,6 +97,15 @@ public function isPublic(): bool
 		return $this->reflection->isPublic();
 	}
 
+	public function isReadOnly(): bool
+	{
+		if (method_exists($this->reflection, 'isReadOnly')) {
+			return $this->reflection->isReadOnly();
+		}
+
+		return false;
+	}
+
 	public function getReadableType(): Type
 	{
 		if ($this->type === null) {
@@ -149,6 +158,11 @@ public function getPhpDocType(): Type
 		return new MixedType();
 	}
 
+	public function hasNativeType(): bool
+	{
+		return $this->nativeType !== null;
+	}
+
 	public function getNativeType(): Type
 	{
 		if ($this->finalNativeType === null) {

src/Reflection/Php/PhpPropertyReflection.php

@@ -43,7 +43,7 @@ public function processNode(Node $node, Scope $scope): array
 		$propertyName = $node->getName();
 		$propertyReflection = $scope->getClassReflection()->getNativeProperty($propertyName);
 
-		if (!$propertyReflection->hasPhpDoc()) {
+		if (!$propertyReflection->hasPhpDocType()) {
 			return [];
 		}