Skip to content

Use nullable return type for TypePart::getTypeNullable() #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use nullable return type for TypePart::getTypeNullable() #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6316db
Test that a PhpParameter is created without explicit setNullable defi…
bnf Jul 3, 2019
b0ad711
Use nullable return type for TypePart::getTypeNullable()
bnf Jun 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/model/parts/TypePart.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public function getTypeDescription(): ?string {
*
* @return bool
*/
public function getNullable(): bool {
public function getNullable(): ?bool {
return $this->typeNullable;
}

Expand Down
7 changes: 7 additions & 0 deletions tests/generator/ParameterGeneratorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,13 @@ public function testPhp73Nullable() {
$this->assertEquals('?float $foo', $generator->generate($param));
}

public function testPhp73NullableDefaultsToFalseWhenUnset() {
$generator = new ModelGenerator(['generateScalarTypeHints' => true, 'generateNullableTypes' => true]);

$param = PhpParameter::create('foo')->setType('float');
$this->assertEquals('float $foo', $generator->generate($param));
}

public function testValues() {
$generator = new ModelGenerator();

Expand Down