Fixed touch command #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * @var RepositoryInterface|\PHPUnit_Framework_MockObject_MockObject | ||
| */ | ||
| public $repository; |
There was a problem hiding this comment.
@dbu changed the annotations to be in proper CS - hope thats ok.
There was a problem hiding this comment.
yeah that is correct. its just tests, otherwise i would say those should be protected and not public.
|
thanks, merged this. if you want to fix visibility of the properties to protected, please just do against master directly (or do you not have commit rights?) |
|
I changed the visibility because we might want to access these properties from a closure - and I normally do not declare properties in tests, so they default to being public. So there is maybe a small "real" reason and another personal coding style creep :) |
|
fine for me, i don't mind for the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Options were being passed with wrong keys.. hmm.