Add more phpstan checks

Author: jaapio

composer.json

@@ -26,7 +26,7 @@
     },
     "autoload-dev": {
         "psr-4": {
-            "phpDocumentor\\Reflection\\": "tests"
+            "phpDocumentor\\Reflection\\": "tests/unit"
         }
     },
     "extra": {

phpstan.neon

@@ -0,0 +1,7 @@
+parameters:
+  ignoreErrors:
+    -
+      message: '#Parameter \#1 \$types of class phpDocumentor\\Reflection\\Types\\Compound constructor expects array<phpDocumentor\\Reflection\\Type>, array<int, string> given\.#'
+      path: %currentWorkingDirectory%/tests/unit/Types/CompoundTest.php
+    - message: '#Parameter \#2 \$fileContents of method phpDocumentor\\Reflection\\Types\\ContextFactory::createForNamespace\(\) expects string, string|false given\.#'
+      path: %currentWorkingDirectory%/tests/unit/Types/ContextFactoryTest.php

src/TypeResolver.php

@@ -97,14 +97,8 @@ public function __construct(FqsenResolver $fqsenResolver = null)
      * replaced with another namespace.
      * @return Type
      */
-    public function resolve($type, Context $context = null)
+    public function resolve(string $type, Context $context = null): Type
     {
-        if (!is_string($type)) {
-            throw new \InvalidArgumentException(
-                'Attempted to resolve type but it appeared not to be a string, received: ' . var_export($type, true)
-            );
-        }
-
         $type = trim($type);
         if (!$type) {
             throw new \InvalidArgumentException('Attempted to resolve "' . $type . '" but it appears to be empty');

tests/unit/CollectionResolverTest.php

@@ -170,10 +170,12 @@ public function testResolvingCollectionOfCollection()
 
         /** @var Collection $valueType */
         $valueType = $resolvedType->getValueType();
+        /** @var Object_ $collectionValueType */
+        $collectionValueType = $valueType->getValueType();
         $this->assertInstanceOf(Types\Collection::class, $valueType);
         $this->assertInstanceOf(Types\Object_::class, $valueType->getValueType());
         $this->assertEquals('\\ArrayObject', (string) $valueType->getFqsen());
-        $this->assertEquals('\\DateTime', (string) $valueType->getValueType()->getFqsen());
+        $this->assertEquals('\\DateTime', (string) $collectionValueType->getFqsen());
 
         /** @var Compound $keyType */
         $keyType = $resolvedType->getKeyType();

tests/unit/FqsenResolverTest.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace phpDocumentor\Reflection\unit;
+namespace phpDocumentor\Reflection;
 
 use phpDocumentor\Reflection\FqsenResolver;
 use phpDocumentor\Reflection\Types\Context;

tests/unit/TypeResolverTest.php

@@ -583,19 +583,6 @@ public function testExceptionIsThrownIfTypeIsEmpty()
         $fixture->resolve(' ', new Context(''));
     }
 
-    /**
-     * @covers ::__construct
-     * @covers ::resolve
-     * @uses \phpDocumentor\Reflection\Types\Context
-     *
-     * @expectedException \InvalidArgumentException
-     */
-    public function testExceptionIsThrownIfTypeIsNotAString()
-    {
-        $fixture = new TypeResolver();
-        $fixture->resolve(['a'], new Context(''));
-    }
-
     /**
      * Returns a list of keywords and expected classes that are created from them.
      *