From e99e01bab26dd42f79986b12acf32a72bf3d7832 Mon Sep 17 00:00:00 2001 From: George Peter Banyard Date: Fri, 25 Sep 2020 14:54:25 +0100 Subject: [PATCH] Fix logic error in PDO --- ext/pdo/pdo_stmt.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ext/pdo/pdo_stmt.c b/ext/pdo/pdo_stmt.c index f010d0453b035..bc48dd0c47ba8 100644 --- a/ext/pdo/pdo_stmt.c +++ b/ext/pdo/pdo_stmt.c @@ -1873,7 +1873,12 @@ int pdo_stmt_setup_fetch_mode(INTERNAL_FUNCTION_PARAMETERS, pdo_stmt_t *stmt, in mode = Z_LVAL(args[skip]); flags = mode & PDO_FETCH_FLAGS; - retval = pdo_stmt_verify_mode(stmt, mode, 0); + /* pdo_stmt_verify_mode() returns a boolean value */ + if (pdo_stmt_verify_mode(stmt, mode, 0)) { + retval = SUCCESS; + } else { + retval = FAILURE; + } } }