From ace3eefa7e986700223c15646d7024ced8626f18 Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Sat, 20 Apr 2024 22:14:10 +0200 Subject: [PATCH] [ci skip] Be more specific about ext-dom incompatibilities in UPGRADING The previous text was put there before I decided to add the new classes. Therefore the only new feature that can affect BC is compareDocumentPosition(). Only when the declaration is incompatible can the user experience errors. --- UPGRADING | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/UPGRADING b/UPGRADING index ad6e5b839a8a0..bcd8282530336 100644 --- a/UPGRADING +++ b/UPGRADING @@ -31,11 +31,10 @@ PHP 8.4 UPGRADE NOTES . The type of PHP_DEBUG and PHP_ZTS constants changed to bool. - DOM: - . New methods and constants were added to some DOM classes. If you inherit - from these and you happen to have a method or property with the same name, - you might encounter errors if the declaration is incompatible. - Consult sections 2. New Features and 6. New Functions for a list of - newly implemented methods and constants. + . Added DOMNode::compareDocumentPosition() and DOMNode::DOCUMENT_POSITION_* + constants. + If you have a method or constant with the same name, you might encounter errors + if the declaration is incompatible. . Some DOM methods previously returned false or a PHP_ERR DOMException if a new node could not be allocated. They consistently throw an INVALID_STATE_ERR DOMException now. This situation is extremely unlikely though and probably