Fix GH-9556 "iterable" alias "array|Traversable" breaks PHP 8.1 code

Author: Girgias

NEWS

@@ -4,6 +4,8 @@ PHP                                                                        NEWS
 
 - Core:
   . Fixed observer class notify with Opcache file_cache_only=1. (ilutov)
+  . Fixed bug GH-9556 ("iterable" alias "array|Traversable" breaks PHP 8.1 code).
+    (Girgias)
 
 - Date:
   . Fixed bug with parsing large negative numbers with the @ notation. (Derick)

Zend/tests/type_declarations/dnf_types/redundant_types/object_and_dnf_type.phpt

@@ -0,0 +1,14 @@
+--TEST--
+A DNF type which contains object is redundant
+--FILE--
+<?php
+
+interface A {}
+interface B {}
+
+function test(): (A&B)|object {}
+
+?>
+===DONE===
+--EXPECTF--
+Fatal error: Type (A&B)|object contains both object and a class type, which is redundant in %s on line %d

Zend/tests/type_declarations/dnf_types/redundant_types/object_and_dnf_type2.phpt

@@ -0,0 +1,14 @@
+--TEST--
+A DNF type which contains object is redundant 2
+--FILE--
+<?php
+
+interface A {}
+interface B {}
+
+function test(): object|(A&B) {}
+
+?>
+===DONE===
+--EXPECTF--
+Fatal error: Type (A&B)|object contains both object and a class type, which is redundant in %s on line %d

Zend/tests/type_declarations/iterable/iterable_alias_redundancy_array_1.phpt

@@ -0,0 +1,12 @@
+--TEST--
+iterable type with array should be redundant
+--FILE--
+<?php
+
+function bar(): array|iterable|null {
+    return null;
+}
+
+?>
+--EXPECTF--
+Fatal error: Duplicate type array is redundant in %s on line %d

Zend/tests/type_declarations/iterable/iterable_alias_redundancy_array_2.phpt

@@ -0,0 +1,12 @@
+--TEST--
+iterable type with array should be redundant
+--FILE--
+<?php
+
+function bar(): iterable|array|null {
+    return null;
+}
+
+?>
+--EXPECTF--
+Fatal error: Duplicate type array is redundant in %s on line %d

Zend/tests/type_declarations/iterable/iterable_alias_redundancy_iterable.phpt

@@ -0,0 +1,12 @@
+--TEST--
+iterable type with second iterable should be redundant
+--FILE--
+<?php
+
+function bar(): iterable|iterable|null {
+    return null;
+}
+
+?>
+--EXPECTF--
+Fatal error: Duplicate type array is redundant in %s on line %d

Zend/tests/type_declarations/iterable/iterable_alias_redundancy_object_1.phpt

@@ -0,0 +1,13 @@
+--TEST--
+iterable type with object should NOT be redundant 1
+--FILE--
+<?php
+
+function bar(): iterable|object|null {
+    return null;
+}
+
+?>
+===DONE===
+--EXPECT--
+===DONE===

Zend/tests/type_declarations/iterable/iterable_alias_redundancy_object_2.phpt

@@ -0,0 +1,13 @@
+--TEST--
+iterable type with object should NOT be redundant 2
+--FILE--
+<?php
+
+function bar(): object|iterable|null {
+    return null;
+}
+
+?>
+===DONE===
+--EXPECT--
+===DONE===

Zend/tests/type_declarations/iterable/iterable_alias_redundancy_object_3.phpt

@@ -0,0 +1,12 @@
+--TEST--
+iterable type with object and class T should be redundant
+--FILE--
+<?php
+
+function bar(): object|iterable|T|null {
+    return null;
+}
+
+?>
+--EXPECTF--
+Fatal error: Type Traversable|T|object|array|null contains both object and a class type, which is redundant in %s on line %d

Zend/tests/type_declarations/iterable/iterable_alias_redundancy_object_4.phpt

@@ -0,0 +1,12 @@
+--TEST--
+iterable type with object and class T should be redundant
+--FILE--
+<?php
+
+function bar(): iterable|object|T|null {
+    return null;
+}
+
+?>
+--EXPECTF--
+Fatal error: Type Traversable|T|object|array|null contains both object and a class type, which is redundant in %s on line %d