Remove redundant check

nielsdos · nielsdos · commit e575ab5b778c · 2024-05-06T19:50:22.000+02:00
There's no point in checking the length, this just wastes time.
diff --git a/ext/phar/stream.c b/ext/phar/stream.c
@@ -63,7 +63,7 @@ php_url* phar_parse_url(php_stream_wrapper *wrapper, const char *filename, const
 	char *arch = NULL, *entry = NULL, *error;
 	size_t arch_len, entry_len;
 
-	if (strlen(filename) < 7 || strncasecmp(filename, "phar://", 7)) {
+	if (strncasecmp(filename, "phar://", 7)) {
 		return NULL;
 	}
 	if (mode[0] == 'a') {

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ php_url* phar_parse_url(php_stream_wrapper wrapper, const char filename, const`
`63`	`63`	`char arch = NULL, entry = NULL, *error;`
`64`	`64`	`size_t arch_len, entry_len;`
`65`	`65`
`66`		`- if (strlen(filename) < 7 \|\| strncasecmp(filename, "phar://", 7)) {`
	`66`	`+ if (strncasecmp(filename, "phar://", 7)) {`
`67`	`67`	`return NULL;`
`68`	`68`	`}`
`69`	`69`	`if (mode[0] == 'a') {`