Skip to content

Commit c9e3879

Browse files
committed
Drop Todo about invalid regex
1 parent 547be3f commit c9e3879

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

ext/mbstring/php_mbregex.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1212,7 +1212,6 @@ PHP_FUNCTION(mb_split)
12121212

12131213
/* create regex pattern buffer */
12141214
if ((re = php_mbregex_compile_pattern(arg_pattern, arg_pattern_len, MBREX(regex_default_options), MBREX(regex_default_syntax))) == NULL) {
1215-
// TODO throw as invalid regex?
12161215
RETURN_FALSE;
12171216
}
12181217

@@ -1309,7 +1308,6 @@ PHP_FUNCTION(mb_ereg_match)
13091308
}
13101309

13111310
if ((re = php_mbregex_compile_pattern(arg_pattern, arg_pattern_len, option, syntax)) == NULL) {
1312-
// TODO throw as invalid regex?
13131311
RETURN_FALSE;
13141312
}
13151313

@@ -1365,7 +1363,6 @@ static void _php_mb_regex_ereg_search_exec(INTERNAL_FUNCTION_PARAMETERS, int mod
13651363
if (arg_pattern) {
13661364
/* create regex pattern buffer */
13671365
if ((MBREX(search_re) = php_mbregex_compile_pattern(arg_pattern, arg_pattern_len, option, syntax)) == NULL) {
1368-
// TODO throw as invalid regex?
13691366
RETURN_FALSE;
13701367
}
13711368
}
@@ -1499,7 +1496,6 @@ PHP_FUNCTION(mb_ereg_search_init)
14991496
if (arg_pattern) {
15001497
/* create regex pattern buffer */
15011498
if ((MBREX(search_re) = php_mbregex_compile_pattern(arg_pattern, arg_pattern_len, option, syntax)) == NULL) {
1502-
// TODO throw as invalid regex?
15031499
RETURN_FALSE;
15041500
}
15051501
}

0 commit comments

Comments
 (0)