Fix a few ZEND_UNREACHABLE() calls

kocsismate · kocsismate · commit 72e8719ed081 · 2020-09-23T10:07:58.000+02:00
diff --git a/ext/dom/document.c b/ext/dom/document.c
@@ -1102,7 +1102,8 @@ PHP_METHOD(DOMDocument, __construct)
 		}
 		intern->document = NULL;
 		if (php_libxml_increment_doc_ref((php_libxml_node_object *)intern, docp) == -1) {
-			RETURN_FALSE;
+			/* docp is always non-null so php_libxml_increment_doc_ref() never returns -1 */
+			ZEND_UNREACHABLE();
 		}
 		php_libxml_increment_node_ptr((php_libxml_node_object *)intern, (xmlNodePtr)docp, (void *)intern);
 	}
diff --git a/ext/standard/net.c b/ext/standard/net.c
@@ -301,7 +301,7 @@ PHP_FUNCTION(net_get_interfaces) {
 	freeifaddrs(addrs);
 #else
 	/* Should never happen as we never register the function */
-	ZEND_UNREACHABLE("No support for net_get_interfaces");
+	ZEND_UNREACHABLE();
 #endif
 }
 /* }}} */

Original file line number	Diff line number	Diff line change
`@@ -1102,7 +1102,8 @@ PHP_METHOD(DOMDocument, __construct)`
`1102`	`1102`	`}`
`1103`	`1103`	`intern->document = NULL;`
`1104`	`1104`	`if (php_libxml_increment_doc_ref((php_libxml_node_object *)intern, docp) == -1) {`
`1105`		`- RETURN_FALSE;`
	`1105`	`+ /* docp is always non-null so php_libxml_increment_doc_ref() never returns -1 */`
	`1106`	`+ ZEND_UNREACHABLE();`
`1106`	`1107`	`}`
`1107`	`1108`	`php_libxml_increment_node_ptr((php_libxml_node_object )intern, (xmlNodePtr)docp, (void )intern);`
`1108`	`1109`	`}`
Original file line number	Diff line number	Diff line change
`@@ -301,7 +301,7 @@ PHP_FUNCTION(net_get_interfaces) {`
`301`	`301`	`freeifaddrs(addrs);`
`302`	`302`	`#else`
`303`	`303`	`/* Should never happen as we never register the function */`
`304`		`- ZEND_UNREACHABLE("No support for net_get_interfaces");`
	`304`	`+ ZEND_UNREACHABLE();`
`305`	`305`	`#endif`
`306`	`306`	`}`
`307`	`307`	`/* }}} */`