Address review comments

Author: SakiTakamachi

ext/bcmath/libbcmath/src/floor_or_ceil.c

@@ -35,8 +35,6 @@
 
 void bc_floor_or_ceil(bc_num num, bool is_floor, bc_num *result)
 {
-	bc_num fractional;
-
 	/* clear result */
 	bc_free_num(result);
 
@@ -51,20 +49,18 @@ void bc_floor_or_ceil(bc_num num, bool is_floor, bc_num *result)
 		return;
 	}
 
-	/* copy fractional part */
-	fractional = bc_new_num(0, num->n_scale);
-	memcpy(fractional->n_value, num->n_value + num->n_len, num->n_scale);
+	/* check fractional part. */
+	size_t count = num->n_scale;
+	char *nptr = num->n_value + num->n_len;
+	while ((count > 0) && (*nptr++ == 0)) count--;
 
-	if (bc_is_zero(fractional)) {
-		goto cleanup;
+	if (count == 0) {
+		return;
 	}
 
 	/* add/sub 1 to/from result */
 	bc_num tmp = _bc_do_add(*result, BCG(_one_), 0);
 	tmp->n_sign = (*result)->n_sign;
 	bc_free_num(result);
 	*result = tmp;
-
-cleanup:
-	bc_free_num(&fractional);
 }

ext/bcmath/libbcmath/src/round.c

@@ -49,7 +49,7 @@ void bc_round(bc_num num, zend_long precision, zend_long mode, bc_num *result)
 	*    end, the 0's are omitted and the number of digits in num is reduced.
 	*    In that case, may end up in the same situation as 2.
 	*/
-	if ((int) num->n_len + precision <= 0) {
+	if (precision < 0 && num->n_len <= labs(precision)) {
 		*result = bc_copy_num(BCG(_zero_));
 		return;
 	}

ext/bcmath/tests/bcround.phpt

@@ -183,6 +183,12 @@ try {
 } catch (Throwable $e) {
     echo $e->getMessage()."\n";
 }
+
+try {
+    bcround('0.001', 0, 1000);
+} catch (Throwable $e) {
+    echo $e->getMessage()."\n";
+}
 ?>
 --EXPECT--
 ========== early return ==========
@@ -842,3 +848,4 @@ try {
 ========== value error ==========
 bcround(): Argument #1 ($num) is not well-formed
 bcround(): Argument #1 ($num) is not well-formed
+bcround(): Argument #3 ($mode) must be a valid rounding mode (PHP_ROUND_*)