Skip to content

Commit 47a5620

Browse files
committed
Fixed memory leak in Zend/tests/bug78999.phpt
1 parent e6b51cc commit 47a5620

File tree

2 files changed

+12
-15
lines changed

2 files changed

+12
-15
lines changed

ext/opcache/jit/zend_jit_trace.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4623,11 +4623,11 @@ static const void *zend_jit_trace(zend_jit_trace_rec *trace_buffer, uint32_t par
46234623
info = zend_jit_trace_type_to_info_ex(type, info);
46244624
if (opline->op1_type == IS_CV
46254625
&& EX_VAR_TO_NUM(opline->op1.var) == j
4626-
&& !(op1_info & MAY_BE_REF)
4627-
&& JIT_G(current_frame)) {
4628-
if (TRACE_FRAME_IS_RETURN_VALUE_USED(JIT_G(current_frame))) {
4626+
&& !(op1_info & (MAY_BE_REF|MAY_BE_OBJECT))) {
4627+
if (JIT_G(current_frame)
4628+
&& TRACE_FRAME_IS_RETURN_VALUE_USED(JIT_G(current_frame))) {
46294629
continue;
4630-
} else if ((op1_info & (MAY_BE_ANY|MAY_BE_UNDEF)) != MAY_BE_OBJECT) {
4630+
} else {
46314631
info |= MAY_BE_NULL;
46324632
}
46334633
}

ext/opcache/jit/zend_jit_x86.dasc

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11361,17 +11361,14 @@ static int zend_jit_return(dasm_State **Dst, const zend_op *opline, const zend_o
1136111361
op1_addr = ZEND_ADDR_MEM_ZVAL(ZREG_R0, 0);
1136211362
}
1136311363
| ZVAL_COPY_VALUE ret_addr, MAY_BE_ANY, op1_addr, op1_info, ZREG_R0, ZREG_R2
11364-
if (JIT_G(trigger) != ZEND_JIT_ON_HOT_TRACE || (op1_info & MAY_BE_REF) || (return_value_used != 1)) {
11365-
if (op1_info & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE)) {
11366-
if (JIT_G(trigger) == ZEND_JIT_ON_HOT_TRACE
11367-
&& !(op1_info & MAY_BE_REF)
11368-
&& op_array->function_name
11369-
&& (op1_info & (MAY_BE_ANY|MAY_BE_UNDEF)) != MAY_BE_OBJECT) {
11370-
| // if (EXPECTED(!(EX_CALL_INFO() & ZEND_CALL_CODE))) ZVAL_NULL(retval_ptr);
11371-
| SET_ZVAL_TYPE_INFO op1_addr, IS_NULL
11372-
} else {
11373-
| TRY_ADDREF op1_info, ah, r2
11374-
}
11364+
if (op1_info & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE)) {
11365+
if (JIT_G(trigger) != ZEND_JIT_ON_HOT_TRACE ||
11366+
(op1_info & (MAY_BE_REF|MAY_BE_OBJECT)) ||
11367+
!op_array->function_name) {
11368+
| TRY_ADDREF op1_info, ah, r2
11369+
} else if (return_value_used != 1) {
11370+
| // if (EXPECTED(!(EX_CALL_INFO() & ZEND_CALL_CODE))) ZVAL_NULL(retval_ptr);
11371+
| SET_ZVAL_TYPE_INFO op1_addr, IS_NULL
1137511372
}
1137611373
}
1137711374
} else {

0 commit comments

Comments
 (0)