When rounding to a precision finer than num, add 0 at the end

Author: SakiTakamachi

ext/bcmath/libbcmath/src/round.c

@@ -37,8 +37,14 @@ void bc_round(bc_num num, zend_long precision, zend_long mode, bc_num *result)
 		*result = bc_copy_num(BCG(_zero_));
 		return;
 	}
+	/* Just like bcadd('1', '1', 4) becomes '2.0000', it pads with zeros at the end if necessary. */
 	if (precision >= 0 && num->n_scale <= precision) {
-		*result = bc_copy_num(num);
+		if (num->n_scale == precision) {
+			*result = bc_copy_num(num);
+		} else if(num->n_scale < precision) {
+			*result = bc_new_num(num->n_len, precision);
+			memcpy((*result)->n_value, num->n_value, num->n_len + num->n_scale);
+		}
 		return;
 	}
 

ext/bcmath/tests/bcround_early_return.phpt

@@ -71,18 +71,18 @@ foreach ($otherModes as $mode) {
 --EXPECT--
                         [123, -4] => 0
                  [123.123456, -4] => 0
-                         [123, 1] => 123
+                         [123, 1] => 123.0
                        [123.5, 1] => 123.5
-                       [123.5, 2] => 123.5
+                       [123.5, 2] => 123.50
  [123.0000000000000000000001, 22] => 123.0000000000000000000001
- [123.0000000000000000000001, 23] => 123.0000000000000000000001
+ [123.0000000000000000000001, 23] => 123.00000000000000000000010
                        [-123, -4] => 0
                 [-123.123456, -4] => 0
-                        [-123, 1] => -123
+                        [-123, 1] => -123.0
                       [-123.5, 1] => -123.5
-                      [-123.5, 2] => -123.5
+                      [-123.5, 2] => -123.50
 [-123.0000000000000000000001, 22] => -123.0000000000000000000001
-[-123.0000000000000000000001, 23] => -123.0000000000000000000001
+[-123.0000000000000000000001, 23] => -123.00000000000000000000010
                            [0, 0] => 0
                          [0.0, 0] => 0
                       [0.0000, 0] => 0