TypeError on invalid resource stream in fclose

Girgias · Girgias · commit 2fbe87748e7f · 2019-12-13T03:24:46.000+01:00
diff --git a/ext/standard/file.c b/ext/standard/file.c
@@ -913,8 +913,8 @@ PHPAPI PHP_FUNCTION(fclose)
 	PHP_STREAM_TO_ZVAL(stream, res);
 
 	if ((stream->flags & PHP_STREAM_FLAG_NO_FCLOSE) != 0) {
-		php_error_docref(NULL, E_WARNING, "%d is not a valid stream resource", stream->res->handle);
-		RETURN_FALSE;
+		zend_type_error("%d is not a valid stream resource", stream->res->handle);
+		return;
 	}
 
 	php_stream_free(stream,

Original file line number	Diff line number	Diff line change
`@@ -913,8 +913,8 @@ PHPAPI PHP_FUNCTION(fclose)`
`913`	`913`	`PHP_STREAM_TO_ZVAL(stream, res);`
`914`	`914`
`915`	`915`	`if ((stream->flags & PHP_STREAM_FLAG_NO_FCLOSE) != 0) {`
`916`		`- php_error_docref(NULL, E_WARNING, "%d is not a valid stream resource", stream->res->handle);`
`917`		`- RETURN_FALSE;`
	`916`	`+ zend_type_error("%d is not a valid stream resource", stream->res->handle);`
	`917`	`+ return;`
`918`	`918`	`}`
`919`	`919`
`920`	`920`	`php_stream_free(stream,`