From 0db277aa43d25b3419fff052250928e39b95e406 Mon Sep 17 00:00:00 2001 From: Emre Dikmen <101067129+fabyo0@users.noreply.github.com> Date: Mon, 9 Dec 2024 22:22:37 +0300 Subject: [PATCH 1/3] Fix: Explicitly set the $escape parameter in fputcsv to address deprecation warning in PHP 8.4 This commit resolves a deprecation warning in PHP 8.4 regarding the $escape parameter of the fputcsv function. The warning indicates that the default value for $escape will change in future PHP versions, requiring it to be explicitly provided. --- reference/filesystem/functions/fputcsv.xml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/reference/filesystem/functions/fputcsv.xml b/reference/filesystem/functions/fputcsv.xml index f3a94fb1b1ce..c7f81f7973b3 100644 --- a/reference/filesystem/functions/fputcsv.xml +++ b/reference/filesystem/functions/fputcsv.xml @@ -127,19 +127,20 @@ ]]> From 311964c1b19e8c6f4266ff36fe25efceea2cad06 Mon Sep 17 00:00:00 2001 From: Emre Dikmen <101067129+fabyo0@users.noreply.github.com> Date: Mon, 9 Dec 2024 22:57:23 +0300 Subject: [PATCH 2/3] Fix: Remove trailing whitespace in fputcsv script --- reference/filesystem/functions/fputcsv.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/reference/filesystem/functions/fputcsv.xml b/reference/filesystem/functions/fputcsv.xml index c7f81f7973b3..89c536b22ceb 100644 --- a/reference/filesystem/functions/fputcsv.xml +++ b/reference/filesystem/functions/fputcsv.xml @@ -139,8 +139,7 @@ foreach ($list as $fields) { fputcsv($fp, $fields, ',', '"', '\\'); } -fclose($fp); - +fclose($fp); ?> ]]> From c9334f32009001ccb20c9bcbeb8c1cdf6fd5b44f Mon Sep 17 00:00:00 2001 From: Emre Dikmen <101067129+fabyo0@users.noreply.github.com> Date: Tue, 10 Dec 2024 11:02:17 +0300 Subject: [PATCH 3/3] Update reference/filesystem/functions/fputcsv.xml Co-authored-by: Gina Peter Banyard --- reference/filesystem/functions/fputcsv.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reference/filesystem/functions/fputcsv.xml b/reference/filesystem/functions/fputcsv.xml index 89c536b22ceb..97dc3fd48aa5 100644 --- a/reference/filesystem/functions/fputcsv.xml +++ b/reference/filesystem/functions/fputcsv.xml @@ -136,7 +136,7 @@ $list = [ $fp = fopen('file.csv', 'w'); foreach ($list as $fields) { - fputcsv($fp, $fields, ',', '"', '\\'); + fputcsv($fp, $fields, ',', '"', ''); } fclose($fp);