Skip to content

Commit b92990c

Browse files
authored
Merge pull request #1 from php-soap/broken-type
Fix broken PHP80 type
2 parents 0e0990b + 0c659f1 commit b92990c

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/HttpBinding/SoapRequest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ final class SoapRequest
1111
private string $location;
1212
private string $action;
1313
private int $version;
14-
private int $oneWay;
14+
private bool $oneWay;
1515

16-
public function __construct(string $request, string $location, string $action, int $version, int $oneWay = 0)
16+
public function __construct(string $request, string $location, string $action, int $version, bool $oneWay = false)
1717
{
1818
$this->request = $request;
1919
$this->location = $location;
@@ -52,7 +52,7 @@ public function isSOAP12(): bool
5252
return $this->getVersion() === self::SOAP_1_2;
5353
}
5454

55-
public function getOneWay(): int
55+
public function getOneWay(): bool
5656
{
5757
return $this->oneWay;
5858
}

tests/Unit/HttpBinding/SoapRequestTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@ final class SoapRequestTest extends TestCase
1111
{
1212
public function test_request()
1313
{
14-
$request = new SoapRequest('requestbody', 'location', 'action', SoapRequest::SOAP_1_1, 0);
14+
$request = new SoapRequest('requestbody', 'location', 'action', SoapRequest::SOAP_1_1, false);
1515

1616
static::assertSame('requestbody', $request->getRequest());
1717
static::assertSame('location', $request->getLocation());
1818
static::assertSame('action', $request->getAction());
1919
static::assertSame(SoapRequest::SOAP_1_1, $request->getVersion());
20-
static::assertSame(0, $request->getOneWay());
20+
static::assertSame(false, $request->getOneWay());
2121
}
2222
}

0 commit comments

Comments
 (0)