Skip to content

Commit 5ea558f

Browse files
committed
Small improvements
1 parent 896f8e0 commit 5ea558f

20 files changed

+35
-13
lines changed

src/Encoder/Context.php

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,23 +11,23 @@
1111

1212
final class Context
1313
{
14-
/**
15-
* TODO : READONLY !
16-
*/
1714
public function __construct(
18-
public /*readonly*/ XsdType $type,
19-
public /*readonly*/ Metadata $metadata,
20-
public /*readonly*/ EncoderRegistry $registry,
21-
public /*readonly*/ Namespaces $namespaces,
22-
public /*readonly*/ BindingUse $bindingUse = BindingUse::LITERAL,
15+
public readonly XsdType $type,
16+
public readonly Metadata $metadata,
17+
public readonly EncoderRegistry $registry,
18+
public readonly Namespaces $namespaces,
19+
public readonly BindingUse $bindingUse = BindingUse::LITERAL,
2320
) {
2421
}
2522

2623
public function withType(XsdType $type): self
2724
{
28-
$new = clone $this;
29-
$new->type = $type;
30-
31-
return $new;
25+
return new self(
26+
$type,
27+
$this->metadata,
28+
$this->registry,
29+
$this->namespaces,
30+
$this->bindingUse,
31+
);
3232
}
3333
}

tests/Integration/DecoderTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
use PHPUnit\Framework\Attributes\CoversClass;
88
use Soap\Encoding\Decoder as SoapDecoder;
9+
use Soap\Encoding\Encoder\Context;
910
use Soap\Encoding\EncoderRegistry;
1011
use Soap\Engine\Decoder;
1112
use Soap\EngineIntegrationTests\AbstractDecoderTest;
@@ -15,6 +16,8 @@
1516
use Soap\WsdlReader\Wsdl1Reader;
1617

1718
#[CoversClass(SoapDecoder::class)]
19+
#[CoversClass(EncoderRegistry::class)]
20+
#[CoversClass(Context::class)]
1821
final class DecoderTest extends AbstractDecoderTest
1922
{
2023
private SoapDecoder $decoder;

tests/Integration/EncoderTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
use Soap\WsdlReader\Wsdl1Reader;
1616

1717
#[CoversClass(SoapEncoder::class)]
18+
#[CoversClass(EncoderRegistry::class)]
19+
#[CoversClass(SoapEncoder\Context::class)]
1820
final class EncoderTest extends AbstractEncoderTest
1921
{
2022
private SoapEncoder $encoder;

tests/PhpCompatibility/Schema023Test.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#[CoversClass(Driver::class)]
1212
#[CoversClass(Encoder::class)]
1313
#[CoversClass(Decoder::class)]
14+
#[CoversClass(Encoder\SoapEnc\SoapArrayEncoder::class)]
1415
final class Schema023Test extends AbstractCompatibilityTests
1516
{
1617
protected string $schema = <<<EOXML

tests/PhpCompatibility/Schema024Test.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#[CoversClass(Driver::class)]
1212
#[CoversClass(Encoder::class)]
1313
#[CoversClass(Decoder::class)]
14+
#[CoversClass(Encoder\SoapEnc\SoapArrayEncoder::class)]
1415
final class Schema024Test extends AbstractCompatibilityTests
1516
{
1617
protected string $schema = <<<EOXML

tests/PhpCompatibility/Schema025Test.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#[CoversClass(Driver::class)]
1212
#[CoversClass(Encoder::class)]
1313
#[CoversClass(Decoder::class)]
14+
#[CoversClass(Encoder\SoapEnc\SoapArrayEncoder::class)]
1415
final class Schema025Test extends AbstractCompatibilityTests
1516
{
1617
protected string $schema = <<<EOXML

tests/PhpCompatibility/Schema026Test.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#[CoversClass(Driver::class)]
1212
#[CoversClass(Encoder::class)]
1313
#[CoversClass(Decoder::class)]
14+
#[CoversClass(Encoder\SoapEnc\SoapArrayEncoder::class)]
1415
final class Schema026Test extends AbstractCompatibilityTests
1516
{
1617
protected string $schema = <<<EOXML

tests/PhpCompatibility/Schema027Test.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
#[CoversClass(Driver::class)]
1313
#[CoversClass(Encoder::class)]
1414
#[CoversClass(Decoder::class)]
15+
#[CoversClass(Encoder\SoapEnc\SoapArrayEncoder::class)]
1516
final class Schema027Test extends AbstractCompatibilityTests
1617
{
1718
protected string $schema = <<<EOXML

tests/PhpCompatibility/Schema028Test.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
#[CoversClass(Driver::class)]
1313
#[CoversClass(Encoder::class)]
1414
#[CoversClass(Decoder::class)]
15+
#[CoversClass(Encoder\SoapEnc\SoapArrayEncoder::class)]
1516
final class Schema028Test extends AbstractCompatibilityTests
1617
{
1718
protected string $schema = <<<EOXML

tests/PhpCompatibility/Schema029Test.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
#[CoversClass(Driver::class)]
1313
#[CoversClass(Encoder::class)]
1414
#[CoversClass(Decoder::class)]
15+
#[CoversClass(Encoder\SoapEnc\SoapArrayEncoder::class)]
1516
final class Schema029Test extends AbstractCompatibilityTests
1617
{
1718
protected string $schema = <<<EOXML

0 commit comments

Comments
 (0)