Fix psalm issues

Author: veewee

psalm.xml

@@ -19,11 +19,4 @@
         <pluginClass class="Psl\Psalm\Plugin"/>
         <pluginClass class="VeeWee\Reflecta\Psalm\Plugin"/>
     </plugins>
-    <issueHandlers>
-        <PossiblyUnusedMethod>
-            <errorLevel type="suppress">
-                <directory name="src"/>
-            </errorLevel>
-        </PossiblyUnusedMethod>
-    </issueHandlers>
 </psalm>

src/Encoder.php

@@ -26,7 +26,9 @@ public function encode(string $method, array $arguments): SoapRequest
         $methodInfo = $this->metadata->getMethods()->fetchByName($method);
         $meta = $methodInfo->getMeta();
         $methodContext = new MethodContext($methodInfo, $this->metadata, $this->registry, $this->namespaces);
-        $soapVersion = $meta->soapVersion()->map(SoapVersion::from(...))->unwrapOr(SoapVersion::SOAP_12);
+        $soapVersion = $meta->soapVersion()
+            ->map(static fn ($version) => SoapVersion::from($version))
+            ->unwrapOr(SoapVersion::SOAP_12);
         $iso = (new RequestEncoder())->iso($methodContext);
 
         return new SoapRequest(

src/Encoder/Method/RequestEncoder.php

@@ -30,7 +30,9 @@ public function iso(MethodContext $context): Iso
     {
         $meta = $context->method->getMeta();
         $context = $context->withBindingUse(
-            $meta->inputBindingUsage()->map(BindingUse::from(...))->unwrapOr(BindingUse::LITERAL)
+            $meta->inputBindingUsage()
+                ->map(static fn ($value) => BindingUse::from($value))
+                ->unwrapOr(BindingUse::LITERAL)
         );
 
         /** @var Iso<list<mixed>, non-empty-string> */
@@ -57,8 +59,11 @@ private function encode(MethodContext $context, array $arguments): string
     {
         $method = $context->method;
         $meta = $method->getMeta();
-        $soapVersion = $meta->soapVersion()->map(SoapVersion::from(...))->unwrapOr(SoapVersion::SOAP_12);
-        $encodingStyle = $meta->inputEncodingStyle()->map(EncodingStyle::from(...));
+        $soapVersion = $meta->soapVersion()
+            ->map(static fn ($value) => SoapVersion::from($value))
+            ->unwrapOr(SoapVersion::SOAP_12);
+        $encodingStyle = $meta->inputEncodingStyle()
+            ->map(static fn ($value) => EncodingStyle::from($value));
 
         $requestParams = map_with_key(
             $method->getParameters(),

src/Encoder/Method/ResponseEncoder.php

@@ -28,7 +28,9 @@ public function iso(MethodContext $context): Iso
     {
         $meta = $context->method->getMeta();
         $context = $context->withBindingUse(
-            $meta->outputBindingUsage()->map(BindingUse::from(...))->unwrapOr(BindingUse::LITERAL)
+            $meta->outputBindingUsage()
+                ->map(static fn ($value) => BindingUse::from($value))
+                ->unwrapOr(BindingUse::LITERAL)
         );
 
         /** @var Iso<list<mixed>, string> */
@@ -56,8 +58,11 @@ private function encode(MethodContext $context, array $arguments): string
             return '';
         }
 
-        $soapVersion = $meta->soapVersion()->map(SoapVersion::from(...))->unwrapOr(SoapVersion::SOAP_12);
-        $encodingStyle = $meta->outputEncodingStyle()->map(EncodingStyle::from(...));
+        $soapVersion = $meta->soapVersion()
+            ->map(static fn ($value) => SoapVersion::from($value))
+            ->unwrapOr(SoapVersion::SOAP_12);
+        $encodingStyle = $meta->outputEncodingStyle()
+            ->map(static fn ($value) => EncodingStyle::from($value));
 
         $returnType = $method->getReturnType();
         $typeContext = $context->createXmlEncoderContextForType($returnType);

src/Encoder/SimpleType/Base64BinaryTypeEncoder.php

@@ -7,6 +7,8 @@
 use Soap\Encoding\Encoder\XmlEncoder;
 use Soap\Encoding\Restriction\WhitespaceRestriction;
 use VeeWee\Reflecta\Iso\Iso;
+use function Psl\Encoding\Base64\decode;
+use function Psl\Encoding\Base64\encode;
 
 /**
  * @implements XmlEncoder<string, string>
@@ -19,8 +21,8 @@ final class Base64BinaryTypeEncoder implements XmlEncoder
     public function iso(Context $context): Iso
     {
         return (new Iso(
-            static fn (string $value): string => base64_encode($value),
-            static fn (string $value): string => WhitespaceRestriction::collapse(base64_decode($value, true)),
+            static fn (string $value): string => encode($value),
+            static fn (string $value): string => WhitespaceRestriction::collapse(decode($value)),
         ));
     }
 }

src/Encoder/SimpleType/HexBinaryTypeEncoder.php

@@ -7,6 +7,8 @@
 use Soap\Encoding\Encoder\XmlEncoder;
 use Soap\Encoding\Restriction\WhitespaceRestriction;
 use VeeWee\Reflecta\Iso\Iso;
+use function Psl\Encoding\Hex\decode;
+use function Psl\Encoding\Hex\encode;
 
 /**
  * @implements XmlEncoder<string, string>
@@ -19,8 +21,8 @@ final class HexBinaryTypeEncoder implements XmlEncoder
     public function iso(Context $context): Iso
     {
         return (new Iso(
-            static fn (string $value): string => mb_strtoupper(bin2hex($value)),
-            static fn (string $value): string => WhitespaceRestriction::collapse(hex2bin($value)),
+            static fn (string $value): string => mb_strtoupper(encode($value)),
+            static fn (string $value): string => WhitespaceRestriction::collapse(decode($value)),
         ));
     }
 }

src/Normalizer/PhpPropertyNameNormalizer.php

@@ -19,7 +19,7 @@ public static function normalize(string $name): string
     }
 
     /**
-     * @param literal-string $regexp
+     * @param non-empty-string $regexp
      */
     private static function camelCase(string $word, string $regexp):string
     {