Fix #238 (memory errors in s_stat_execute_cb)

krakjoe · krakjoe · commit 6ee96cad7be5 · 2016-04-04T06:40:56.000+01:00
diff --git a/php_memcached.c b/php_memcached.c
@@ -2635,8 +2635,7 @@ memcached_return s_stat_execute_cb (php_memcached_instance_st instance, const ch
 		zval zv;
 		array_init(&zv);
 
-		server_values = &zv;
-		add_assoc_zval_ex(return_value, server_key, server_key_len, server_values);
+		server_values = zend_hash_str_add(Z_ARRVAL_P(return_value), server_key, server_key_len, &zv);
 	}
 
 	spprintf (&buffer, 0, "%.*s", value_length, value);

Original file line number	Diff line number	Diff line change
`@@ -2635,8 +2635,7 @@ memcached_return s_stat_execute_cb (php_memcached_instance_st instance, const ch`
`2635`	`2635`	`zval zv;`
`2636`	`2636`	`array_init(&zv);`
`2637`	`2637`
`2638`		`- server_values = &zv;`
`2639`		`- add_assoc_zval_ex(return_value, server_key, server_key_len, server_values);`
	`2638`	`+ server_values = zend_hash_str_add(Z_ARRVAL_P(return_value), server_key, server_key_len, &zv);`
`2640`	`2639`	`}`
`2641`	`2640`
`2642`	`2641`	`spprintf (&buffer, 0, "%.*s", value_length, value);`