Skip to content
This repository was archived by the owner on Jan 16, 2018. It is now read-only.

Conversation

@joelwurtz
Copy link
Member

Set httplug to dev master as target branch has been merged into master

composer.json Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for @dev, composer knows that dev-something is dev stability

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should i remove @dev for message-factory also ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

message-factory has a branch-alias for 0.2. unless @sagikazarmark wants to bump that to 1.0, you could change to ~0.2@dev

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.2 is fine for now. At least I don't really care, until httplug 1.0alpha is out 😛

@dbu
Copy link
Contributor

dbu commented Oct 22, 2015

ups, thanks

@sagikazarmark
Copy link
Member

I would actually be happier with a branch alias. Not sure if it is correctly set in httplug.

@joelwurtz
Copy link
Member Author

It's good for httplug, but there is some fails with message factory, utils and discovery package, i just update the socket adapter with last changes and need to do some "hacks" in the composer.json : https://github.com/joelwurtz/socket-adapter-temp/blob/master/composer.json

@sagikazarmark
Copy link
Member

Sorry, I probably wasn't clear: the required httplug version should be ~1.0@dev, and it should be correctly set in httplug.

@joelwurtz
Copy link
Member Author

Should be good

sagikazarmark added a commit that referenced this pull request Oct 22, 2015
Updating httplug dependency
@sagikazarmark sagikazarmark merged commit 5dabe55 into php-http:master Oct 22, 2015
@joelwurtz joelwurtz deleted the patch-1 branch November 8, 2015 15:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants