-
Notifications
You must be signed in to change notification settings - Fork 8
Set httplug to dev master #5
Conversation
composer.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for @dev, composer knows that dev-something is dev stability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should i remove @dev for message-factory also ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message-factory has a branch-alias for 0.2. unless @sagikazarmark wants to bump that to 1.0, you could change to ~0.2@dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.2 is fine for now. At least I don't really care, until httplug 1.0alpha is out 😛
|
ups, thanks |
|
I would actually be happier with a branch alias. Not sure if it is correctly set in httplug. |
|
It's good for httplug, but there is some fails with message factory, utils and discovery package, i just update the socket adapter with last changes and need to do some "hacks" in the composer.json : https://github.com/joelwurtz/socket-adapter-temp/blob/master/composer.json |
|
Sorry, I probably wasn't clear: the required httplug version should be |
|
Should be good |
Updating httplug dependency
Set httplug to dev master as target branch has been merged into master