This repository was archived by the owner on Jan 16, 2018. It is now read-only.
Implementation separation #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
composer.json
Outdated
Contributor
There was a problem hiding this comment.
can we avoid this dependency? i guess if we would use the guzzle promises, or put them into a separate repo. but then its a lot of repos.
Member
Author
There was a problem hiding this comment.
The EmulateAsyncClient uses two traits from the Tools repo. Also, the promises are moved to the tools repo as well, which are used in the same class.
sagikazarmark
force-pushed
the
implementation_separation
branch
2 times, most recently
from
5f78bfe to
70f007c
Compare
EmulateAsyncClient uses helper traits Use client tools package Remove EmulateAsyncClient and client-tools dependency
sagikazarmark
force-pushed
the
implementation_separation
branch
from
70f007c to
16018c3
Compare
sagikazarmark
added a commit
that referenced
this pull request
Dec 15, 2015
Move Promises and Async/Sync Emulators/Decorators to client-tools
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.