drop php 5 because build no longer works, test with php 7.3 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
changed the title
dbu
force-pushed
the
php-upgrade
branch
2 times, most recently
from
532fe09 to
9c2fd1e
Compare
xabbuh
reviewed
Nov 18, 2019
Contributor
Author
|
good point, fixed the branch alias. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Test with PHP 7.3
Drop tests with PHP 5
Why?
Drop PHP 5 because travis-ci does not properly support them anymore, and they are so outdated that we should not use them anymore.
Checklist