Add test for URI with multiple slashes #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
approved these changes
May 13, 2021
Contributor
dbu
left a comment
dbu
left a comment
There was a problem hiding this comment.
agreed, according to https://datatracker.ietf.org/doc/html/rfc3986#section-3.3 a segment can be 0 length, leading to consequtive slashes.
Contributor
Author
|
ping @Nyholm |
Nyholm
approved these changes
Jun 20, 2021
Member
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
Lovely. Thank you for the PR and the review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen implementation violating the spec RFC 3986, e.g. zendframework/zend-diactoros@68fc742
So let's add a proper test for this.