Skip to content

Cache-Plugin: update for usage with PSR-17 StreamFactory in 2.0 #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2023
Merged

Cache-Plugin: update for usage with PSR-17 StreamFactory in 2.0 #315

merged 1 commit into from
Nov 15, 2023

Conversation

@glaubinix
Copy link
Contributor

@glaubinix glaubinix commented Nov 15, 2023

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Related tickets Updates docs to match changes introduced in php-http/cache-plugin#87
Documentation if this is a new feature, link to pull request in https://github.com/php-http/documentation that adds relevant documentation
License MIT

What's in this PR?

Adjusted docs for changes to the cache-plugin in this PR

ToDo

  • Is there some way to have v1 and v2 be shown in the docs at the same time, or is it ok if this only shows v2?

dbu
dbu approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. we could mention the old way for version 1, but the current version 1 also accepts the new PSR17 factory, so i think that is enough.

@dbu dbu merged commit b1f61a3 into php-http:main Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbu dbu dbu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@glaubinix @dbu