Skip to content

Conversation

@Nyholm
Copy link
Member

@Nyholm Nyholm commented Aug 22, 2016

Related to #123

@dbu
Copy link
Contributor

dbu commented Aug 22, 2016

👍

i think having external images for those is fine. can you check if you get sphinx to not complain about that? i found http://stackoverflow.com/questions/12772927/specifying-an-online-image-in-sphinx-restructuredtext-format - maybe suppress_warnings = ['image.nonlocal_uri'] is enough?

@Nyholm
Copy link
Member Author

Nyholm commented Aug 22, 2016

Thank you for the review.

Hm, suppress_warnings = ['image.nonlocal_uri'] in conf.py did not work. I'll check this out later.. I have a meeting now.

@Nyholm
Copy link
Member Author

Nyholm commented Aug 23, 2016

You were correct. I was running and old version of sphinx.

@Nyholm
Copy link
Member Author

Nyholm commented Aug 23, 2016

I've also updated the path to the Swap logo. I added it here: php-http/httplug.github.io#6

I think we should limit the number of logos here to six and then add more at httplug.io.

@dbu dbu merged commit 44cbd7b into php-http:master Aug 23, 2016
@dbu
Copy link
Contributor

dbu commented Aug 23, 2016

thanks tobias!

agreed to limit to 6. if there are more, lets try to show the most known projects here.

@Nyholm
Copy link
Member Author

Nyholm commented Aug 23, 2016

Awesome.

Thank you for merging.

@Nyholm Nyholm deleted the third-party branch August 23, 2016 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants