Skip to content

add PluginClientFactory comments #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2017
Merged

add PluginClientFactory comments #83

merged 1 commit into from
Jul 10, 2017

Conversation

@fbourigault
Copy link
Contributor

@fbourigault fbourigault commented Jul 10, 2017

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets related to #71
Documentation n/a
License MIT

As request by @dbu in #71, this add a few comments to the PluginClientFactory class.

dbu
dbu approved these changes Jul 10, 2017
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@Nyholm Nyholm merged commit bc3f994 into php-http:master Jul 10, 2017
@fbourigault fbourigault deleted the improve-plugin-client-factory-documentation branch July 10, 2017 13:09
@fbourigault fbourigault mentioned this pull request Aug 22, 2017
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbu dbu dbu approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fbourigault @dbu @Nyholm