Skip to content

Fix for the build with --prefer-lowest #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix for the build with --prefer-lowest #30

wants to merge 1 commit into from

Conversation

@Nyholm
Copy link
Member

@Nyholm Nyholm commented Jul 26, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
Documentation n/a
License MIT

@sagikazarmark
Copy link
Member

sagikazarmark commented Jul 26, 2016

Do we actually need that version here? Or just a dependency needs it? I would rather find the reason why this doesn't work as intended instead of this update.

@Nyholm
Copy link
Member Author

Nyholm commented Jul 26, 2016

I know you would Mark. This is me being pragmatic to solve the build error. The difference between message-factory:1.0.0 and 1.0.2 is that the latter has Puli bindings (if I remember correctly)

So no, we do not actually need that version here.

@dbu
Copy link
Contributor

dbu commented Jul 26, 2016

not sure if its worth the effort to figure out why it does not work. there is no harm in upping the requriement to the factory...

@sagikazarmark
Copy link
Member

sagikazarmark commented Jul 26, 2016

I found the problem: composer/composer#5355

@sagikazarmark sagikazarmark deleted the Nyholm-patch-1 branch July 26, 2016 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Nyholm @sagikazarmark @dbu