cleanups found with phpstan #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
requested changes
Nov 25, 2021
Member
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
Thank you.
It looks great. Just remove phpstan from composer.json and I’ll be happy.
src/Plugin/RetryPlugin.php
Outdated
| } | ||
|
|
||
| $time = call_user_func($this->exceptionDelay, $request, $exception, $this->retryStorage[$chainIdentifier]); | ||
| \assert(is_int($time)); |
Member
There was a problem hiding this comment.
Will this benefit the user?
If it is just to convince phpstan we can add comments.
Contributor
There was a problem hiding this comment.
Better to add a /**@var int */ or whatever. Agreed.
Contributor
Author
There was a problem hiding this comment.
this way the user gets a warning if the user func returns the wrong thing.
but i can also put the annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adjust to new phpstan version, cleanup some phpdoc