[2.0] Remove plugin chain debug (#119)

Complete removal of debug_plugins

Author: Jean85

spec/PluginClientSpec.php

@@ -87,47 +87,4 @@ function it_throws_loop_exception(HttpClient $httpClient, RequestInterface $requ
 
         $this->shouldThrow('Http\Client\Common\Exception\LoopException')->duringSendRequest($request);
     }
-
-    function it_injects_debug_plugins(HttpClient $httpClient, ResponseInterface $response, RequestInterface $request, Plugin $plugin0, Plugin $plugin1, Plugin $debugPlugin)
-    {
-        $plugin0
-            ->handleRequest(
-                $request,
-                Argument::type('callable'),
-                Argument::type('callable')
-            )
-            ->shouldBeCalledTimes(1)
-            ->will(function ($args) {
-                return $args[1]($args[0]);
-            })
-        ;
-        $plugin1
-            ->handleRequest(
-                $request,
-                Argument::type('callable'),
-                Argument::type('callable')
-            )
-            ->shouldBeCalledTimes(1)
-            ->will(function ($args) {
-                return $args[1]($args[0]);
-            })
-        ;
-
-        $debugPlugin
-            ->handleRequest(
-                $request,
-                Argument::type('callable'),
-                Argument::type('callable')
-            )
-            ->shouldBeCalledTimes(3)
-            ->will(function ($args) {
-                return $args[1]($args[0]);
-            })
-        ;
-
-        $httpClient->sendRequest($request)->willReturn($response);
-
-        $this->beConstructedWith($httpClient, [$plugin0, $plugin1], ['debug_plugins'=>[$debugPlugin]]);
-        $this->sendRequest($request);
-    }
 }

src/PluginClient.php

@@ -46,7 +46,6 @@ final class PluginClient implements HttpClient, HttpAsyncClient
      * @param array                      $options {
      *
      *     @var int      $max_restarts
-     *     @var Plugin[] $debug_plugins an array of plugins that are injected between each normal plugin
      * }
      *
      * @throws \RuntimeException if client is not an instance of HttpClient or HttpAsyncClient
@@ -131,16 +130,7 @@ private function createPluginChain($pluginList, callable $clientCallable)
     {
         $firstCallable = $lastCallable = $clientCallable;
 
-        /*
-         * Inject debug plugins between each plugin.
-         */
-        $pluginListWithDebug = $this->options['debug_plugins'];
-        foreach ($pluginList as $plugin) {
-            $pluginListWithDebug[] = $plugin;
-            $pluginListWithDebug = array_merge($pluginListWithDebug, $this->options['debug_plugins']);
-        }
-
-        while ($plugin = array_pop($pluginListWithDebug)) {
+        while ($plugin = array_pop($pluginList)) {
             $lastCallable = function (RequestInterface $request) use ($plugin, $lastCallable, &$firstCallable) {
                 return $plugin->handleRequest($request, $lastCallable, $firstCallable);
             };