Do not deprecate alias as it changed a lot in different Symfony versions #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
approved these changes
Jul 26, 2021
Collaborator
dbu
left a comment
dbu
left a comment
There was a problem hiding this comment.
yeah that makes sense to me. not worth it to do a complicated thing to support all various symfony versions.
we will eventually deprecate the httplug interface itself i think, and that should be enough warning. while the interface exists, we will want to keep autowiring it working anyways.
Collaborator
|
thanks for the quick fix. i tagged https://github.com/php-http/HttplugBundle/releases/tag/1.22.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Turns out that
Alias::setDeprecatedchanged a lot between Symfony versions. I couldn't find a way to distinguish between them so decided to just remove the deprecation for now.