Skip to content

Conversation

@Nyholm
Copy link
Member

@Nyholm Nyholm commented Feb 4, 2018

This will fix our broken master.

Related to symfony/symfony#25891

@dbu dbu merged commit 8c9149b into master Feb 4, 2018
@dbu dbu deleted the patch-1 branch February 4, 2018 18:43
@dbu
Copy link
Collaborator

dbu commented Feb 4, 2018

thanks!

@xabbuh
Copy link
Member

xabbuh commented Feb 4, 2018

@Nyholm Can you explain what this fixture was meant to test? Would it maybe be worth to adapt the Configuration class to maintain the previous behaviour?

@Nyholm
Copy link
Member Author

Nyholm commented Feb 5, 2018

This test is suppose to test if heaven falls down if you do not write any configuration. Im all for modifying Configuration but I was not sure how to do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants