cache-plugin is not a hard dependency to use this bundle

Author: dbu

CHANGELOG.md

@@ -13,6 +13,8 @@ The change log describes what is "Added", "Removed", "Changed" or "Fixed" betwee
 ### Changed
 
 - Removed `twig/twig` dependency
+- Removed hard dependency on `php-http/cache-plugin`. If you want to use the
+  caching plugin, you need to require it in your project.
 
 ## 1.14.0
 

DependencyInjection/Configuration.php

@@ -700,6 +700,7 @@ private function createCachePluginNode()
         $cache = $builder->root('cache');
         $cache
             ->canBeEnabled()
+            ->info('Configure HTTP caching, requires the php-http/cache-plugin package')
             ->addDefaultsIfNotSet()
             ->children()
                 ->scalarNode('cache_pool')

DependencyInjection/HttplugExtension.php

@@ -8,6 +8,7 @@
 use Http\Client\Common\HttpMethodsClient;
 use Http\Client\Common\HttpMethodsClientInterface;
 use Http\Client\Common\Plugin\AuthenticationPlugin;
+use Http\Client\Common\Plugin\CachePlugin;
 use Http\Client\Common\PluginClient;
 use Http\Client\Common\PluginClientFactory;
 use Http\Client\HttpClient;
@@ -17,6 +18,7 @@
 use Http\Message\Authentication\Wsse;
 use Http\Mock\Client as MockClient;
 use Psr\Http\Message\UriInterface;
+use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\DependencyInjection\Alias;
 use Symfony\Component\DependencyInjection\ChildDefinition;
@@ -175,6 +177,9 @@ private function configurePluginByName($name, Definition $definition, array $con
     {
         switch ($name) {
             case 'cache':
+                if (!class_exists(CachePlugin::class)) {
+                    throw new InvalidConfigurationException('To use the cache plugin, you need to require php-http/cache-plugin in your project');
+                }
                 $options = $config['config'];
                 if (!empty($options['cache_key_generator'])) {
                     $options['cache_key_generator'] = new Reference($options['cache_key_generator']);

composer.json

@@ -19,7 +19,6 @@
         "php": "^5.5 || ^7.0",
         "php-http/client-common": "^1.9 || ^2.0",
         "php-http/client-implementation": "^1.0",
-        "php-http/cache-plugin": "^1.6",
         "php-http/discovery": "^1.0",
         "php-http/httplug": "^1.0 || ^2.0",
         "php-http/logger-plugin": "^1.1",
@@ -37,6 +36,7 @@
         "guzzlehttp/psr7": "^1.0",
         "matthiasnoback/symfony-dependency-injection-test": "^1.1 || ^2.3",
         "nyholm/nsa": "^1.1",
+        "php-http/cache-plugin": "^1.6",
         "php-http/guzzle6-adapter": "^1.1.1 || ^2.0.1",
         "php-http/promise": "^1.0",
         "php-http/mock-client": "^1.2",
@@ -57,6 +57,7 @@
     },
     "suggest": {
         "twig/twig": "Add this to your require-dev section when using the WebProfilerBundle",
+        "php-http/cache-plugin": "To configure clients that cache responses",
         "php-http/mock-client": "Add this to your require-dev section to mock HTTP responses easily"
     },
     "autoload": {