Refactored

Author: Nyholm

DependencyInjection/HttplugExtension.php

@@ -5,6 +5,7 @@
 use Http\HttplugBundle\ClientFactory\DummyClient;
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Definition;
 use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\HttpKernel\DependencyInjection\Extension;
@@ -92,73 +93,66 @@ protected function configureClients(ContainerBuilder $container, array $config)
         }
     }
 
+    /**
+     * @param ContainerBuilder $container
+     * @param array $config
+     */
     protected function configurePlugins(ContainerBuilder $container, array $config)
     {
-        if ($config['authentication']['enabled']) {
-            $container->getDefinition('httplug.plugin.authentication')
-                ->replaceArgument(0, new Reference($config['authentication']['authentication']));
-        } else {
-            $container->removeDefinition('httplug.plugin.authentication');
-        }
-
-        if ($config['cache']['enabled']) {
-            $container->getDefinition('httplug.plugin.cache')
-                ->replaceArgument(0, new Reference($config['cache']['cache_pool']))
-                ->replaceArgument(1, new Reference($config['cache']['stream_factory']))
-                ->replaceArgument(2, $config['cache']['config']);
-        } else {
-            $container->removeDefinition('httplug.plugin.cache');
-        }
-
-        if ($config['cookie']['enabled']) {
-            $container->getDefinition('httplug.plugin.cookie')
-                ->replaceArgument(0, new Reference($config['cookie']['cookie_jar']));
-        } else {
-            $container->removeDefinition('httplug.plugin.cookie');
-        }
-
-        if ($config['decoder']['enabled']) {
-            $container->getDefinition('httplug.plugin.decoder')
-                ->replaceArgument(0, $config['decoder']['use_content_encoding']);
-        } else {
-            $container->removeDefinition('httplug.plugin.decoder');
-        }
-
-        if ($config['history']['enabled']) {
-            $container->getDefinition('httplug.plugin.history')
-                ->replaceArgument(0, new Reference($config['history']['journal']));
-        } else {
-            $container->removeDefinition('httplug.plugin.history');
-        }
-
-        if ($config['logger']['enabled']) {
-            $container->getDefinition('httplug.plugin.logger')
-                ->replaceArgument(0, new Reference($config['logger']['logger']))
-                ->replaceArgument(1, new Reference($config['logger']['formatter']));
-        } else {
-            $container->removeDefinition('httplug.plugin.logger');
-        }
-
-        if ($config['redirect']['enabled']) {
-            $container->getDefinition('httplug.plugin.redirect')
-                ->replaceArgument(0, $config['redirect']['preserve_header'])
-                ->replaceArgument(1, $config['redirect']['use_default_for_multiple']);
-        } else {
-            $container->removeDefinition('httplug.plugin.redirect');
+        foreach ($config as $name => $pluginConfig) {
+            $pluginId = 'httplug.plugin.'.$name;
+            if ($config[$name]['enabled']) {
+                $def = $container->getDefinition($pluginId);
+                $this->configurePluginByName($name, $def, $pluginConfig);
+            } else {
+                $container->removeDefinition($pluginId);
+            }
         }
 
-        if ($config['retry']['enabled']) {
-            $container->getDefinition('httplug.plugin.retry')
-                ->replaceArgument(0, $config['retry']['retry']);
-        } else {
-            $container->removeDefinition('httplug.plugin.retry');
-        }
+    }
 
-        if ($config['stopwatch']['enabled']) {
-            $container->getDefinition('httplug.plugin.stopwatch')
-                ->replaceArgument(0, new Reference($config['stopwatch']['stopwatch']));
-        } else {
-            $container->removeDefinition('httplug.plugin.stopwatch');
+    /**
+     * @param string $name
+     * @param Definition $definition
+     * @param array $config
+     */
+    private function configurePluginByName($name, Definition $definition, array $config)
+    {
+        switch ($name) {
+            case 'authentication':
+                $definition->replaceArgument(0, new Reference($config['authentication']));
+                break;
+            case 'cache':
+                $definition
+                    ->replaceArgument(0, new Reference($config['cache_pool']))
+                    ->replaceArgument(1, new Reference($config['stream_factory']))
+                    ->replaceArgument(2, $config['config']);
+                break;
+            case 'cookie':
+                $definition->replaceArgument(0, new Reference($config['cookie_jar']));
+                break;
+            case 'decoder':
+                $definition->addArgument($config['use_content_encoding']);
+                break;
+            case 'history':
+                $definition->replaceArgument(0, new Reference($config['journal']));
+                break;
+            case 'logger':
+                $definition
+                    ->replaceArgument(0, new Reference($config['logger']))
+                    ->replaceArgument(1, new Reference($config['formatter']));
+                break;
+            case 'redirect':
+                $definition
+                    ->addArgument($config['preserve_header'])
+                    ->addArgument($config['use_default_for_multiple']);
+                break;
+            case 'retry':
+                $definition->addArgument($config['retry']);
+                break;
+            case 'stopwatch':
+                $definition->replaceArgument(0, new Reference($config['stopwatch']));
+                break;
         }
     }
 }