Added info()

Author: Nyholm

DependencyInjection/Configuration.php

@@ -124,15 +124,23 @@ protected function configurePlugins(ArrayNodeDefinition $root)
                     ->arrayNode('authentication')
                     ->canBeEnabled()
                         ->children()
-                            ->scalarNode('authentication')->isRequired()->cannotBeEmpty()->end()
+                            ->scalarNode('authentication')
+                                ->info('This must be a service id to a service implementing Http\Message\Authentication')
+                                ->isRequired()
+                                ->cannotBeEmpty()
+                            ->end()
                         ->end()
                     ->end() // End authentication plugin
 
                     ->arrayNode('cache')
                     ->canBeEnabled()
                     ->addDefaultsIfNotSet()
                         ->children()
-                            ->scalarNode('cache_pool')->isRequired()->cannotBeEmpty()->end()
+                            ->scalarNode('cache_pool')
+                                ->info('This must be a service id to a service implementing Psr\Cache\CacheItemPoolInterface')
+                                ->isRequired()
+                                ->cannotBeEmpty()
+                            ->end()
                             ->scalarNode('stream_factory')->cannotBeEmpty()->defaultValue('httplug.stream_factory')->end()
                             ->arrayNode('config')
                                 ->children()
@@ -146,7 +154,11 @@ protected function configurePlugins(ArrayNodeDefinition $root)
                     ->arrayNode('cookie')
                     ->canBeEnabled()
                         ->children()
-                            ->scalarNode('cookie_jar')->isRequired()->cannotBeEmpty()->end()
+                            ->scalarNode('cookie_jar')
+                                ->info('This must be a service id to a service implementing Http\Message\CookieJar')
+                                ->isRequired()
+                                ->cannotBeEmpty()
+                            ->end()
                         ->end()
                     ->end() // End cookie plugin
 
@@ -161,16 +173,27 @@ protected function configurePlugins(ArrayNodeDefinition $root)
                     ->arrayNode('history')
                     ->canBeEnabled()
                         ->children()
-                            ->scalarNode('journal')->isRequired()->cannotBeEmpty()->end()
+                            ->scalarNode('journal')
+                                ->info('This must be a service id to a service implementing Http\Client\Plugin\Journal')
+                                ->isRequired()
+                                ->cannotBeEmpty()
+                            ->end()
                         ->end()
                     ->end() // End history plugin
 
                     ->arrayNode('logger')
                     ->canBeDisabled()
                     ->addDefaultsIfNotSet()
                         ->children()
-                            ->scalarNode('logger')->defaultValue('logger')->cannotBeEmpty()->end()
-                            ->scalarNode('formatter')->defaultNull()->end()
+                            ->scalarNode('logger')
+                                ->info('This must be a service id to a service implementing Psr\Log\LoggerInterface')
+                                ->defaultValue('logger')
+                                ->cannotBeEmpty()
+                            ->end()
+                            ->scalarNode('formatter')
+                                ->info('This must be a service id to a service implementing Http\Message\Formatter')
+                                ->defaultNull()
+                            ->end()
                         ->end()
                     ->end() // End logger plugin
 
@@ -195,7 +218,11 @@ protected function configurePlugins(ArrayNodeDefinition $root)
                     ->canBeDisabled()
                     ->addDefaultsIfNotSet()
                         ->children()
-                            ->scalarNode('stopwatch')->defaultValue('debug.stopwatch')->cannotBeEmpty()->end()
+                            ->scalarNode('stopwatch')
+                                ->info('This must be a service id to a service extending Symfony\Component\Stopwatch\Stopwatch')
+                                ->defaultValue('debug.stopwatch')
+                                ->cannotBeEmpty()
+                            ->end()
                         ->end()
                     ->end() // End stopwatch plugin
 

DependencyInjection/HttplugExtension.php

@@ -62,7 +62,7 @@ public function load(array $configs, ContainerBuilder $container)
      * @param ContainerBuilder $container
      * @param array            $config
      */
-    protected function configureClients(ContainerBuilder $container, array $config)
+    private function configureClients(ContainerBuilder $container, array $config)
     {
         $first = isset($config['clients']['default']) ? 'default' : null;
         foreach ($config['clients'] as $name => $arguments) {
@@ -104,7 +104,7 @@ protected function configureClients(ContainerBuilder $container, array $config)
      * @param ContainerBuilder $container
      * @param array            $config
      */
-    protected function configurePlugins(ContainerBuilder $container, array $config)
+    private function configurePlugins(ContainerBuilder $container, array $config)
     {
         foreach ($config as $name => $pluginConfig) {
             $pluginId = 'httplug.plugin.'.$name;